From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Rik van Riel <riel@redhat.com>,
Linux RT Users <linux-rt-users@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 1/3] MM: remove unused quiet_vmstat function
Date: Wed, 03 May 2017 15:40:08 -0300 [thread overview]
Message-ID: <20170503184039.737799631@redhat.com> (raw)
In-Reply-To: 20170503184007.174707977@redhat.com
[-- Attachment #1: remove-vmstat-quiet --]
[-- Type: text/plain, Size: 2250 bytes --]
Remove unused quiet_vmstat function.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
include/linux/vmstat.h | 1 -
mm/vmstat.c | 25 -------------------------
2 files changed, 26 deletions(-)
Index: linux-2.6-git-disable-vmstat-worker/include/linux/vmstat.h
===================================================================
--- linux-2.6-git-disable-vmstat-worker.orig/include/linux/vmstat.h 2017-04-24 18:52:42.957724687 -0300
+++ linux-2.6-git-disable-vmstat-worker/include/linux/vmstat.h 2017-04-24 18:53:15.086793496 -0300
@@ -233,7 +233,6 @@
extern void __dec_zone_state(struct zone *, enum zone_stat_item);
extern void __dec_node_state(struct pglist_data *, enum node_stat_item);
-void quiet_vmstat(void);
void cpu_vm_stats_fold(int cpu);
void refresh_zone_stat_thresholds(void);
Index: linux-2.6-git-disable-vmstat-worker/mm/vmstat.c
===================================================================
--- linux-2.6-git-disable-vmstat-worker.orig/mm/vmstat.c 2017-04-24 18:52:42.957724687 -0300
+++ linux-2.6-git-disable-vmstat-worker/mm/vmstat.c 2017-04-24 18:53:53.075874785 -0300
@@ -1657,31 +1657,6 @@
}
/*
- * Switch off vmstat processing and then fold all the remaining differentials
- * until the diffs stay at zero. The function is used by NOHZ and can only be
- * invoked when tick processing is not active.
- */
-void quiet_vmstat(void)
-{
- if (system_state != SYSTEM_RUNNING)
- return;
-
- if (!delayed_work_pending(this_cpu_ptr(&vmstat_work)))
- return;
-
- if (!need_update(smp_processor_id()))
- return;
-
- /*
- * Just refresh counters and do not care about the pending delayed
- * vmstat_update. It doesn't fire that often to matter and canceling
- * it would be too expensive from this path.
- * vmstat_shepherd will take care about that for us.
- */
- refresh_cpu_vm_stats(false);
-}
-
-/*
* Shepherd worker thread that checks the
* differentials of processors that have their worker
* threads for vm statistics updates disabled because of
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Rik van Riel <riel@redhat.com>,
Linux RT Users <linux-rt-users@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 1/3] MM: remove unused quiet_vmstat function
Date: Wed, 03 May 2017 15:40:08 -0300 [thread overview]
Message-ID: <20170503184039.737799631@redhat.com> (raw)
In-Reply-To: 20170503184007.174707977@redhat.com
[-- Attachment #1: remove-vmstat-quiet --]
[-- Type: text/plain, Size: 2023 bytes --]
Remove unused quiet_vmstat function.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
include/linux/vmstat.h | 1 -
mm/vmstat.c | 25 -------------------------
2 files changed, 26 deletions(-)
Index: linux-2.6-git-disable-vmstat-worker/include/linux/vmstat.h
===================================================================
--- linux-2.6-git-disable-vmstat-worker.orig/include/linux/vmstat.h 2017-04-24 18:52:42.957724687 -0300
+++ linux-2.6-git-disable-vmstat-worker/include/linux/vmstat.h 2017-04-24 18:53:15.086793496 -0300
@@ -233,7 +233,6 @@
extern void __dec_zone_state(struct zone *, enum zone_stat_item);
extern void __dec_node_state(struct pglist_data *, enum node_stat_item);
-void quiet_vmstat(void);
void cpu_vm_stats_fold(int cpu);
void refresh_zone_stat_thresholds(void);
Index: linux-2.6-git-disable-vmstat-worker/mm/vmstat.c
===================================================================
--- linux-2.6-git-disable-vmstat-worker.orig/mm/vmstat.c 2017-04-24 18:52:42.957724687 -0300
+++ linux-2.6-git-disable-vmstat-worker/mm/vmstat.c 2017-04-24 18:53:53.075874785 -0300
@@ -1657,31 +1657,6 @@
}
/*
- * Switch off vmstat processing and then fold all the remaining differentials
- * until the diffs stay at zero. The function is used by NOHZ and can only be
- * invoked when tick processing is not active.
- */
-void quiet_vmstat(void)
-{
- if (system_state != SYSTEM_RUNNING)
- return;
-
- if (!delayed_work_pending(this_cpu_ptr(&vmstat_work)))
- return;
-
- if (!need_update(smp_processor_id()))
- return;
-
- /*
- * Just refresh counters and do not care about the pending delayed
- * vmstat_update. It doesn't fire that often to matter and canceling
- * it would be too expensive from this path.
- * vmstat_shepherd will take care about that for us.
- */
- refresh_cpu_vm_stats(false);
-}
-
-/*
* Shepherd worker thread that checks the
* differentials of processors that have their worker
* threads for vm statistics updates disabled because of
next prev parent reply other threads:[~2017-05-03 18:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 18:40 [patch 0/3] per-CPU vmstat thresholds and vmstat worker disablement (v2) Marcelo Tosatti
2017-05-03 18:40 ` Marcelo Tosatti
2017-05-03 18:40 ` Marcelo Tosatti [this message]
2017-05-03 18:40 ` [patch 1/3] MM: remove unused quiet_vmstat function Marcelo Tosatti
2017-05-10 13:36 ` Rik van Riel
2017-05-10 13:36 ` Rik van Riel
2017-05-03 18:40 ` [patch 2/3] MM: allow per-cpu vmstat_threshold configuration Marcelo Tosatti
2017-05-03 18:40 ` Marcelo Tosatti
2017-05-03 18:40 ` [patch 3/3] MM: allow per-cpu vmstat_worker configuration Marcelo Tosatti
2017-05-03 18:40 ` Marcelo Tosatti
2017-05-10 15:34 ` Rik van Riel
2017-05-10 15:34 ` Rik van Riel
2017-05-11 15:33 ` Marcelo Tosatti
2017-05-11 15:33 ` Marcelo Tosatti
2017-05-16 1:31 ` [lkp-robot] [MM] 3e38a07a66: ltp.proc01.fail kernel test robot
2017-05-16 1:31 ` kernel test robot
2017-05-16 1:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503184039.737799631@redhat.com \
--to=mtosatti@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.