All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
	Mason <slash.tmp@free.fr>
Subject: Re: [PATCH] tango_nand.c: fix ecc.stats_corrected in empty flash case
Date: Wed, 3 May 2017 22:02:07 +0200	[thread overview]
Message-ID: <20170503200207.GB17315@amd> (raw)
In-Reply-To: <20170502142016.024416d2@bbrezillon>

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hi!

> Anyway, I think we went too far. I was just arguing that never updating
> stats->corrected just because you don't know the exact number of
> bitflips is not necessarily a better idea than updating corrected with
> a potentially invalid number of bitflips. At least the 2nd approach
> shows that bitflips were present on the media.

I have to agree here. Indication of "we have errors" is important.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-05-03 20:02 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 12:13 fsl_ifc_nand: are blank pages protected by ECC? Pavel Machek
2017-04-19 21:18 ` Boris Brezillon
2017-04-19 22:15   ` Pavel Machek
2017-04-19 22:27     ` Boris Brezillon
2017-04-20 11:40       ` Pavel Machek
2017-04-20 12:15         ` Boris Brezillon
2017-04-21 10:51         ` [PATCH] nand_base: optimize checking of erased buffers Pavel Machek
2017-05-17 11:27           ` Mason
2017-05-17 11:39             ` Mason
2017-05-17 11:52             ` Pavel Machek
2017-05-17 12:22           ` [PATCH] fsl_ifc_nand: fix handing of bit flips in erased nand Pavel Machek
2017-05-17 12:32             ` Boris Brezillon
2017-05-17 13:00               ` Pavel Machek
2017-05-17 13:25                 ` Boris Brezillon
2017-05-17 20:03                   ` [PATCH] mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Pavel Machek
2017-05-31 20:59                     ` [PATCHv2] " Pavel Machek
2017-05-31 22:59                       ` Darwin Dingel
2017-06-01  1:09                       ` Darwin Dingel
2017-06-01 13:12                         ` Pavel Machek
2017-06-01 13:21                           ` Boris Brezillon
2017-06-07  7:31                             ` Boris Brezillon
2017-04-21 10:08   ` fsl_ifc_nand: are blank pages protected by ECC? Pavel Machek
2017-04-21 10:12     ` Richard Weinberger
2017-04-21 12:04     ` Boris Brezillon
2017-04-21 13:37     ` Pavel Machek
2017-04-21 13:49       ` Boris Brezillon
2017-04-22  7:01         ` Pavel Machek
2017-04-22 10:40         ` [PATCH] tango_nand.c: fix ecc.stats_corrected in empty flash case Pavel Machek
2017-04-24  8:58           ` Marc Gonzalez
2017-04-24  9:03             ` Pavel Machek
2017-05-02  9:42             ` Boris Brezillon
2017-05-02 11:52               ` Marc Gonzalez
2017-05-02 12:20                 ` Boris Brezillon
2017-05-03 20:02                   ` Pavel Machek [this message]
2017-05-03 20:04             ` Pavel Machek
2017-05-04  8:42               ` Boris Brezillon
2017-05-12 15:34                 ` [PATCH] mtd: nand: tango: Update ecc_stats.corrected Marc Gonzalez
2017-05-15  8:56                   ` Boris Brezillon
2017-05-15 20:47                   ` Boris Brezillon
2017-05-17 12:04                 ` [PATCH] tango_nand.c: fix ecc.stats_corrected in empty flash case Pavel Machek
2017-04-23  9:58         ` tango_nand: is logic right in error cases? (was Re: fsl_ifc_nand: are blank pages protected by ECC?) Pavel Machek
2017-04-24  7:12           ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503200207.GB17315@amd \
    --to=pavel@ucw.cz \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marc_gonzalez@sigmadesigns.com \
    --cc=slash.tmp@free.fr \
    --cc=thibaud_cornic@sigmadesigns.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.