* [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
@ 2017-05-03 10:45 ` Colin King
0 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-05-03 10:45 UTC (permalink / raw)
To: Liam Breck, Andrew F . Davis, Pali Rohár, Sebastian Reichel,
linux-pm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function bq27xxx_battery_settings can be made static as it
does not need to be in global scope.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/power/supply/bq27xxx_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index 7152370b9d61..06f15da32464 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
/* assume bq27xxx_battery_update() is called hereafter */
}
-void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
+static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
{
struct power_supply_battery_info info = {};
unsigned int min, max;
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
2017-05-03 10:45 ` Colin King
(?)
@ 2017-05-04 6:30 ` Liam Breck
-1 siblings, 0 replies; 7+ messages in thread
From: Liam Breck @ 2017-05-04 6:30 UTC (permalink / raw)
To: Colin King; +Cc: Andrew F . Davis, Sebastian Reichel, linux-pm
[dropped some CCs]
Hi Colin,
On Wed, May 3, 2017 at 3:45 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
Thanks for flagging that. I've fixed it in the v13 series (just posted
to linux-pm); v12 landed in -next prematurely.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
> /* assume bq27xxx_battery_update() is called hereafter */
> }
>
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> {
> struct power_supply_battery_info info = {};
> unsigned int min, max;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
2017-05-03 10:45 ` Colin King
@ 2017-05-04 8:10 ` Pali Rohár
-1 siblings, 0 replies; 7+ messages in thread
From: Pali Rohár @ 2017-05-04 8:10 UTC (permalink / raw)
To: Colin King
Cc: Liam Breck, Andrew F . Davis, Sebastian Reichel, linux-pm,
kernel-janitors, linux-kernel
On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
> /* assume bq27xxx_battery_update() is called hereafter */
> }
>
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> {
> struct power_supply_battery_info info = {};
> unsigned int min, max;
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
@ 2017-05-04 8:10 ` Pali Rohár
0 siblings, 0 replies; 7+ messages in thread
From: Pali Rohár @ 2017-05-04 8:10 UTC (permalink / raw)
To: Colin King
Cc: Liam Breck, Andrew F . Davis, Sebastian Reichel, linux-pm,
kernel-janitors, linux-kernel
On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
> /* assume bq27xxx_battery_update() is called hereafter */
> }
>
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> {
> struct power_supply_battery_info info = {};
> unsigned int min, max;
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
2017-05-03 10:45 ` Colin King
@ 2017-05-04 15:24 ` Sebastian Reichel
-1 siblings, 0 replies; 7+ messages in thread
From: Sebastian Reichel @ 2017-05-04 15:24 UTC (permalink / raw)
To: Colin King
Cc: Liam Breck, Andrew F . Davis, Pali Rohár, linux-pm,
kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Hi,
On Wed, May 03, 2017 at 11:45:54AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I dropped Liam's patches instead.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static
@ 2017-05-04 15:24 ` Sebastian Reichel
0 siblings, 0 replies; 7+ messages in thread
From: Sebastian Reichel @ 2017-05-04 15:24 UTC (permalink / raw)
To: Colin King
Cc: Liam Breck, Andrew F . Davis, Pali Rohár, linux-pm,
kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Hi,
On Wed, May 03, 2017 at 11:45:54AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I dropped Liam's patches instead.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread