All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Javier González" <jg@lightnvm.io>
Cc: mb@lightnvm.io, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 1/2] lightnvm: create cmd before allocating request
Date: Thu, 4 May 2017 04:27:38 -0700	[thread overview]
Message-ID: <20170504112738.GA22269@infradead.org> (raw)
In-Reply-To: <1493803145-18082-1-git-send-email-javier@cnexlabs.com>

On Wed, May 03, 2017 at 11:19:04AM +0200, Javier Gonz�lez wrote:
> Create nvme command before allocating a request using
> nvme_alloc_request, which uses the command direction. Up until now, the
> command has been zeroized, so all commands have been allocated as a
> read operation.

Hah.. Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Javier González" <jg@lightnvm.io>
Cc: mb@lightnvm.io, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 1/2] lightnvm: create cmd before allocating request
Date: Thu, 4 May 2017 04:27:38 -0700	[thread overview]
Message-ID: <20170504112738.GA22269@infradead.org> (raw)
In-Reply-To: <1493803145-18082-1-git-send-email-javier@cnexlabs.com>

On Wed, May 03, 2017 at 11:19:04AM +0200, Javier González wrote:
> Create nvme command before allocating a request using
> nvme_alloc_request, which uses the command direction. Up until now, the
> command has been zeroized, so all commands have been allocated as a
> read operation.

Hah.. Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  parent reply	other threads:[~2017-05-04 11:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03  9:19 [PATCH 1/2] lightnvm: create cmd before allocating request Javier González
2017-05-03  9:19 ` [PATCH 2/2] lightnvm: fix bad back free on error path Javier González
2017-05-04  8:04   ` Matias Bjørling
2017-05-04 11:27   ` Christoph Hellwig
2017-05-04  8:04 ` [PATCH 1/2] lightnvm: create cmd before allocating request Matias Bjørling
2017-05-04 11:27 ` Christoph Hellwig [this message]
2017-05-04 11:27   ` Christoph Hellwig
2017-05-04 13:53 ` Jens Axboe
2017-05-04 13:53   ` Jens Axboe
2017-05-04 13:55   ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504112738.GA22269@infradead.org \
    --to=hch@infradead.org \
    --cc=javier@cnexlabs.com \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.