All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Anson Huang <Anson.Huang@nxp.com>,
	Peter Chen <Peter.Chen@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override
Date: Thu, 4 May 2017 20:50:53 +0800	[thread overview]
Message-ID: <20170504125052.GP18578@dragon> (raw)
In-Reply-To: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com>

On Tue, Apr 25, 2017 at 07:57:59PM +0300, Leonard Crestez wrote:
> The board file for imx6sx-dbg overrides cpufreq operating points to use

s/imx6sx-dbg/imx6sx-sdb

> higher voltages. This is done because the board has a shared rail for
> VDD_ARM_IN and VDD_SOC_IN and when using LDO bypass the shared voltage
> needs to be a value suitable for both ARM and SOC.
> 
> This was introduced in:
> 
> commit 54183bd7f766 ("ARM: imx6sx-sdb: add revb board and make it default")
> 
> This only only applies to LDO bypass mode, a feature not present in

s/only only/only

> upstream. When LDOs are enabled the effect is to use higher voltages than
> necesarry for no good reason.
> 
> Setting these higher voltages can make some boards fail to boot with ugly

Please make it clear it's RevC board.

> semi-random crashes, reminiscent of memory corruption. These failures
> happen the first time the lowest idle state is used. Remove the OPP
> override in order to fix those crashes.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Please add tags for Fixes and Cc stable.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override
Date: Thu, 4 May 2017 20:50:53 +0800	[thread overview]
Message-ID: <20170504125052.GP18578@dragon> (raw)
In-Reply-To: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com>

On Tue, Apr 25, 2017 at 07:57:59PM +0300, Leonard Crestez wrote:
> The board file for imx6sx-dbg overrides cpufreq operating points to use

s/imx6sx-dbg/imx6sx-sdb

> higher voltages. This is done because the board has a shared rail for
> VDD_ARM_IN and VDD_SOC_IN and when using LDO bypass the shared voltage
> needs to be a value suitable for both ARM and SOC.
> 
> This was introduced in:
> 
> commit 54183bd7f766 ("ARM: imx6sx-sdb: add revb board and make it default")
> 
> This only only applies to LDO bypass mode, a feature not present in

s/only only/only

> upstream. When LDOs are enabled the effect is to use higher voltages than
> necesarry for no good reason.
> 
> Setting these higher voltages can make some boards fail to boot with ugly

Please make it clear it's RevC board.

> semi-random crashes, reminiscent of memory corruption. These failures
> happen the first time the lowest idle state is used. Remove the OPP
> override in order to fix those crashes.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Please add tags for Fixes and Cc stable.

Shawn

  parent reply	other threads:[~2017-05-04 12:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 16:57 [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override Leonard Crestez
2017-04-25 16:57 ` Leonard Crestez
2017-04-25 16:57 ` Leonard Crestez
2017-04-25 17:02 ` Fabio Estevam
2017-04-25 17:02   ` Fabio Estevam
2017-04-25 17:02   ` Fabio Estevam
2017-04-25 17:02     ` Fabio Estevam
2017-04-25 17:23     ` Leonard Crestez
2017-04-25 17:23       ` Leonard Crestez
2017-04-25 17:26       ` Fabio Estevam
2017-04-25 17:26         ` Fabio Estevam
2017-04-25 17:28       ` Marek Vasut
2017-04-25 17:28         ` Marek Vasut
2017-04-25 17:28         ` Marek Vasut
2017-05-03 13:57         ` Shawn Guo
2017-05-03 13:57           ` Shawn Guo
2017-05-03 14:26           ` Marek Vasut
2017-05-03 14:26             ` Marek Vasut
2017-05-03 14:32             ` Marek Vasut
2017-05-03 14:32               ` Marek Vasut
2017-05-03 14:41               ` Shawn Guo
2017-05-03 14:41                 ` Shawn Guo
2017-05-03 14:51                 ` Marek Vasut
2017-05-03 14:51                   ` Marek Vasut
2017-05-03 14:58             ` Leonard Crestez
2017-05-03 14:58               ` Leonard Crestez
2017-05-03 15:59               ` Marek Vasut
2017-05-03 15:59                 ` Marek Vasut
2017-05-03 17:58                 ` Leonard Crestez
2017-05-03 17:58                   ` Leonard Crestez
2017-05-03 19:33                   ` Marek Vasut
2017-05-03 19:33                     ` Marek Vasut
2017-05-04  9:42                     ` Leonard Crestez
2017-05-04  9:42                       ` Leonard Crestez
2017-05-04 10:06                       ` Marek Vasut
2017-05-04 10:06                         ` Marek Vasut
2017-05-04 12:44                         ` Shawn Guo
2017-05-04 12:44                           ` Shawn Guo
2017-05-04 13:08                           ` Marek Vasut
2017-05-04 13:08                             ` Marek Vasut
2017-05-04 13:41                             ` Shawn Guo
2017-05-04 13:41                               ` Shawn Guo
2017-05-04 14:34                               ` Marek Vasut
2017-05-04 14:34                                 ` Marek Vasut
2017-05-04 14:34                                 ` Marek Vasut
2017-05-05  1:18                                 ` Shawn Guo
2017-05-05  1:18                                   ` Shawn Guo
2017-05-05 10:11                                   ` Leonard Crestez
2017-05-05 10:11                                     ` Leonard Crestez
2017-04-27  1:17 ` Peter Chen
2017-04-27  1:17   ` Peter Chen
2017-04-27  1:17   ` Peter Chen
2017-05-04 11:43   ` Shawn Guo
2017-05-04 11:43     ` Shawn Guo
2017-05-04 11:46     ` Fabio Estevam
2017-05-04 11:46       ` Fabio Estevam
2017-05-04 12:50 ` Shawn Guo [this message]
2017-05-04 12:50   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504125052.GP18578@dragon \
    --to=shawnguo@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=Peter.Chen@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.