All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2, 1/5] mmc: dt: add compatible into eSDHC required properties
Date: Fri, 5 May 2017 10:36:52 +0800	[thread overview]
Message-ID: <20170505023651.GW18578@dragon> (raw)
In-Reply-To: <1493894940-47452-2-git-send-email-yangbo.lu@nxp.com>

On Thu, May 04, 2017 at 06:48:56PM +0800, Yangbo Lu wrote:
> This patch is to add compatible into eSDHC required properties.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> Changes for v2:
> 	- Added this patch.
> ---
>  Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> index dedfb02..b04b248 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> @@ -7,6 +7,7 @@ This file documents differences between the core properties described
>  by mmc.txt and the properties used by the sdhci-esdhc driver.
>  
>  Required properties:
> +  - compatible : should be "fsl,esdhc", or "fsl,<chip>-esdhc".

I think either supported <chip> or the compatible should be listed
explicitly.

Shawn

>    - interrupt-parent : interrupt source phandle.
>    - clock-frequency : specifies eSDHC base clock frequency.
>  
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yangbo Lu <yangbo.lu-3arQi8VN3Tc@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Harninder Rai <harninder.rai-3arQi8VN3Tc@public.gmane.org>,
	Xiaobo Xie <xiaobo.xie-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [v2, 1/5] mmc: dt: add compatible into eSDHC required properties
Date: Fri, 5 May 2017 10:36:52 +0800	[thread overview]
Message-ID: <20170505023651.GW18578@dragon> (raw)
In-Reply-To: <1493894940-47452-2-git-send-email-yangbo.lu-3arQi8VN3Tc@public.gmane.org>

On Thu, May 04, 2017 at 06:48:56PM +0800, Yangbo Lu wrote:
> This patch is to add compatible into eSDHC required properties.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu-3arQi8VN3Tc@public.gmane.org>
> ---
> Changes for v2:
> 	- Added this patch.
> ---
>  Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> index dedfb02..b04b248 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> @@ -7,6 +7,7 @@ This file documents differences between the core properties described
>  by mmc.txt and the properties used by the sdhci-esdhc driver.
>  
>  Required properties:
> +  - compatible : should be "fsl,esdhc", or "fsl,<chip>-esdhc".

I think either supported <chip> or the compatible should be listed
explicitly.

Shawn

>    - interrupt-parent : interrupt source phandle.
>    - clock-frequency : specifies eSDHC base clock frequency.
>  
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-05-05  2:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 10:48 [v2, 0/5] Add eSDHC UHS-I/HS200 mode support for ls1012a/ls1046a/ls208xa Yangbo Lu
2017-05-04 10:48 ` Yangbo Lu
2017-05-04 10:48 ` [v2, 1/5] mmc: dt: add compatible into eSDHC required properties Yangbo Lu
2017-05-04 10:48   ` Yangbo Lu
2017-05-05  2:36   ` Shawn Guo [this message]
2017-05-05  2:36     ` Shawn Guo
2017-05-05  3:01     ` Y.B. Lu
2017-05-05  3:01       ` Y.B. Lu
2017-05-05  3:18       ` Shawn Guo
2017-05-05  3:18         ` Shawn Guo
2017-05-08 16:36       ` Rob Herring
2017-05-08 16:36         ` Rob Herring
2017-05-09  2:51         ` Y.B. Lu
2017-05-09  2:51           ` Y.B. Lu
2017-05-04 10:48 ` [v2, 2/5] arm64: dts: ls1046a: support SD UHS-I and eMMC HS200 on RDB Yangbo Lu
2017-05-04 10:48   ` Yangbo Lu
2017-05-04 10:48 ` [v2, 3/5] arm64: dts: ls208xa: support SD UHS-I on RDB and eMMC HS200 on QDS Yangbo Lu
2017-05-04 10:48   ` Yangbo Lu
2017-05-04 10:48 ` [v2, 4/5] arm64: dts: ls1012a: add eSDHC nodes Yangbo Lu
2017-05-04 10:48   ` Yangbo Lu
2017-05-04 10:49 ` [v2, 5/5] arm64: dts: ls1088a: add esdhc node Yangbo Lu
2017-05-04 10:49   ` Yangbo Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170505023651.GW18578@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.