From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org, thuth@redhat.com,
dgilbert@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests: Ignore another built executable
Date: Fri, 5 May 2017 14:55:04 +0800 [thread overview]
Message-ID: <20170505065504.GA21435@lemon.lan> (raw)
In-Reply-To: <20170428085407.GC23819@redhat.com>
On Fri, 04/28 09:54, Daniel P. Berrange wrote:
> On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> > Commit 78f86a2b7 added a new test, but forgot to exclude the built
> > binary from version control.
>
> CC Fam
>
> I wonder if the patchew test system could be made to report an error
> if git identifies built files that are not ignored.
>
If we had .git in the docker tests that patchew uses, it would be easy. That's
an unfortunate dependency for a number of other features, I'll see what I can
do.
Fam
WARNING: multiple messages have this Message-ID (diff)
From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org, thuth@redhat.com,
dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] tests: Ignore another built executable
Date: Fri, 5 May 2017 14:55:04 +0800 [thread overview]
Message-ID: <20170505065504.GA21435@lemon.lan> (raw)
In-Reply-To: <20170428085407.GC23819@redhat.com>
On Fri, 04/28 09:54, Daniel P. Berrange wrote:
> On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> > Commit 78f86a2b7 added a new test, but forgot to exclude the built
> > binary from version control.
>
> CC Fam
>
> I wonder if the patchew test system could be made to report an error
> if git identifies built files that are not ignored.
>
If we had .git in the docker tests that patchew uses, it would be easy. That's
an unfortunate dependency for a number of other features, I'll see what I can
do.
Fam
next prev parent reply other threads:[~2017-05-05 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 2:23 [Qemu-trivial] [PATCH] tests: Ignore another built executable Eric Blake
2017-04-28 2:23 ` [Qemu-devel] " Eric Blake
2017-04-28 2:58 ` [Qemu-trivial] " Thomas Huth
2017-04-28 2:58 ` [Qemu-devel] " Thomas Huth
2017-04-28 8:54 ` [Qemu-trivial] " Daniel P. Berrange
2017-04-28 8:54 ` Daniel P. Berrange
2017-05-05 6:55 ` Fam Zheng [this message]
2017-05-05 6:55 ` Fam Zheng
2017-05-05 6:18 ` [Qemu-trivial] " Michael Tokarev
2017-05-05 6:18 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505065504.GA21435@lemon.lan \
--to=famz@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.