All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/kyua: fix unmet dependencies
@ 2017-05-05 19:08 Yann E. MORIN
  2017-05-05 19:15 ` Yann E. MORIN
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yann E. MORIN @ 2017-05-05 19:08 UTC (permalink / raw)
  To: buildroot

lutok is a lua module, so it depends on ! static libs. However, the
dependency is implicit, being done because the lua modules are sourced
globally under an if-block, and thus it is not easy to find that
dependency.

Propagate that dependency to kyua, which was missing it (because it is
not a lua module, so was missing the dependency).

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
 package/kyua/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/kyua/Config.in b/package/kyua/Config.in
index 4f887b0e0a..6444b8c9e0 100644
--- a/package/kyua/Config.in
+++ b/package/kyua/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_KYUA
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
 	depends on !BR2_PACKAGE_LUAJIT # lutok
+	depends on !BR2_STATIC_LIBS # lutok
 	depends on BR2_USE_MMU # atf
 	select BR2_PACKAGE_ATF
 	select BR2_PACKAGE_LUTOK
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/kyua: fix unmet dependencies
  2017-05-05 19:08 [Buildroot] [PATCH] package/kyua: fix unmet dependencies Yann E. MORIN
@ 2017-05-05 19:15 ` Yann E. MORIN
  2017-05-05 19:57 ` Peter Korsgaard
  2017-05-15  9:42 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2017-05-05 19:15 UTC (permalink / raw)
  To: buildroot

S?bastien, All,

On 2017-05-05 21:08 +0200, Yann E. MORIN spake thusly:
> lutok is a lua module, so it depends on ! static libs. However, the
> dependency is implicit, being done because the lua modules are sourced
> globally under an if-block, and thus it is not easy to find that
> dependency.
> 
> Propagate that dependency to kyua, which was missing it (because it is
> not a lua module, so was missing the dependency).
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>

You can try on current master (cfe6112780):

    $ make KCONFIG_SEED=0x6DC29DCB randconfig
    warning: (BR2_PACKAGE_KYUA) selects BR2_PACKAGE_LUTOK which has
    unmet direct dependencies (BR2_PACKAGE_HAS_LUAINTERPRETER &&
    !BR2_STATIC_LIBS && BR2_INSTALL_LIBSTDCPP && !BR2_PACKAGE_LUAJIT)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/kyua: fix unmet dependencies
  2017-05-05 19:08 [Buildroot] [PATCH] package/kyua: fix unmet dependencies Yann E. MORIN
  2017-05-05 19:15 ` Yann E. MORIN
@ 2017-05-05 19:57 ` Peter Korsgaard
  2017-05-15  9:42 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-05-05 19:57 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > lutok is a lua module, so it depends on ! static libs. However, the
 > dependency is implicit, being done because the lua modules are sourced
 > globally under an if-block, and thus it is not easy to find that
 > dependency.

 > Propagate that dependency to kyua, which was missing it (because it is
 > not a lua module, so was missing the dependency).

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
 > ---
 >  package/kyua/Config.in | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/kyua/Config.in b/package/kyua/Config.in
 > index 4f887b0e0a..6444b8c9e0 100644
 > --- a/package/kyua/Config.in
 > +++ b/package/kyua/Config.in
 > @@ -3,6 +3,7 @@ config BR2_PACKAGE_KYUA
 >  	depends on BR2_INSTALL_LIBSTDCPP
 >  	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
 >  	depends on !BR2_PACKAGE_LUAJIT # lutok
 > +	depends on !BR2_STATIC_LIBS # lutok
 >  	depends on BR2_USE_MMU # atf
 >  	select BR2_PACKAGE_ATF
 >  	select BR2_PACKAGE_LUTOK

Committed after propagating this dependency to the toolchain comment as
well, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/kyua: fix unmet dependencies
  2017-05-05 19:08 [Buildroot] [PATCH] package/kyua: fix unmet dependencies Yann E. MORIN
  2017-05-05 19:15 ` Yann E. MORIN
  2017-05-05 19:57 ` Peter Korsgaard
@ 2017-05-15  9:42 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-05-15  9:42 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > lutok is a lua module, so it depends on ! static libs. However, the
 > dependency is implicit, being done because the lua modules are sourced
 > globally under an if-block, and thus it is not easy to find that
 > dependency.

 > Propagate that dependency to kyua, which was missing it (because it is
 > not a lua module, so was missing the dependency).

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-05-15  9:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-05 19:08 [Buildroot] [PATCH] package/kyua: fix unmet dependencies Yann E. MORIN
2017-05-05 19:15 ` Yann E. MORIN
2017-05-05 19:57 ` Peter Korsgaard
2017-05-15  9:42 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.