From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@163.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
fw@strlen.de, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf] netfilter: don't setup nat info for confirmed ct
Date: Sat, 6 May 2017 21:09:35 +0200 [thread overview]
Message-ID: <20170506190935.GA20672@breakpoint.cc> (raw)
In-Reply-To: <20170506122802.5630-1-zlpnobody@163.com>
Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> We cannot setup nat info if the ct has been confirmed already, else,
> different cpu may race to handle the same ct.
Yes.
> In extreme situation,
> we may hit the "BUG_ON(nf_nat_initialized(ct, maniptype))" in the
> nf_nat_setup_info.
Right, before my change we did call
nf_ct_nat_ext_add() unconditionally and that made us return NF_ACCEPT
for confirmed conntracks without nat extension.
So this fix looks correct to me, thanks Liping!
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2017-05-06 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 12:28 [PATCH nf] netfilter: don't setup nat info for confirmed ct Liping Zhang
2017-05-06 19:09 ` Florian Westphal [this message]
2017-05-15 16:36 ` Pablo Neira Ayuso
2017-05-15 16:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170506190935.GA20672@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.