All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joao Pinto <Joao.Pinto@synopsys.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	netdev <netdev@vger.kernel.org>,
	Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 0/4] stmmac: pci: Fix crash on Intel Galileo Gen2
Date: Mon,  8 May 2017 17:14:18 +0300	[thread overview]
Message-ID: <20170508141422.39612-1-andriy.shevchenko@linux.intel.com> (raw)

Due to misconfiguration of PCI driver for Intel Quark the user will get
a kernel crash:

# udhcpc -i eth0
udhcpc: started, v1.26.2
stmmaceth 0000:00:14.6 eth0: device MAC address 98:4f:ee:05:ac:47
Generic PHY stmmac-a6:01: attached PHY driver [Generic PHY] (mii_bus:phy_addr=stmmac-a6:01, irq=-1)
stmmaceth 0000:00:14.6 eth0: IEEE 1588-2008 Advanced Timestamp supported
stmmaceth 0000:00:14.6 eth0: registered PTP clock
IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready

udhcpc: sending discover

stmmaceth 0000:00:14.6 eth0: Link is Up - 100Mbps/Full - flow control off
IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: stmmac_xmit+0xf1/0x1080

Fix this by adding necessary settings.

P.S. I split fix to three patches according to what each of them adds.

Andy Shevchenko (4):
  stmmac: pci: set default number of rx and tx queues
  stmmac: pci: TX and RX queue priority configuration
  stmmac: pci: RX queue routing configuration
  stmmac: pci: split out common_default_data() helper

 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 41 +++++++++++-------------
 1 file changed, 18 insertions(+), 23 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-05-08 14:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 14:14 Andy Shevchenko [this message]
2017-05-08 14:14 ` [PATCH v1 1/4] stmmac: pci: set default number of rx and tx queues Andy Shevchenko
2017-05-08 14:18   ` Joao Pinto
2017-05-08 14:22   ` Giuseppe CAVALLARO
2017-05-08 14:14 ` [PATCH v1 2/4] stmmac: pci: TX and RX queue priority configuration Andy Shevchenko
2017-05-08 14:18   ` Joao Pinto
2017-05-08 14:14 ` [PATCH v1 3/4] stmmac: pci: RX queue routing configuration Andy Shevchenko
2017-05-08 14:18   ` Joao Pinto
2017-05-08 14:14 ` [PATCH v1 4/4] stmmac: pci: split out common_default_data() helper Andy Shevchenko
2017-05-08 14:19   ` Joao Pinto
2017-05-08 17:34 ` [PATCH v1 0/4] stmmac: pci: Fix crash on Intel Galileo Gen2 Jan Kiszka
2017-05-08 19:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170508141422.39612-1-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=davem@davemloft.net \
    --cc=jan.kiszka@siemens.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.