From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields
Date: Tue, 9 May 2017 14:18:25 +0200 [thread overview]
Message-ID: <20170509121825.GA9983@krava> (raw)
In-Reply-To: <20170508162134.6265-1-andi@firstfloor.org>
On Mon, May 08, 2017 at 09:21:34AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> With perf script it is common that we just want to add or remove a field.
> Currently this requires figuring out the long list of default fields and
> specifying them first, and then adding/removing the new field.
>
> This patch adds a new + - syntax to merely add or remove fields,
> that allows more succint and clearer command lines
>
> For example to remove the comm field from PMU samples:
>
> Previously
>
> perf script -F tid,cpu,time,event,sym,ip,dso,period
> 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms])
>
> with the new syntax
>
> perf script -F -comm
> 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms])
>
> The new syntax cannot be mixed with normal overriding.
so the -F option for 'type:' does not have default set,
and it looks like the +- don't make sense there:
[jolsa@krava perf]$ ./perf script -F hw:+comm | head -3
ex
ex
ex
jirka
next prev parent reply other threads:[~2017-05-09 12:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 16:21 [PATCH] perf, tools, script: Allow adding and removing fields Andi Kleen
2017-05-09 12:18 ` Jiri Olsa [this message]
2017-05-09 12:29 ` Andi Kleen
2017-05-09 13:45 ` Jiri Olsa
2017-05-09 14:34 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2017-06-02 15:48 Andi Kleen
2017-06-08 12:59 ` Milian Wolff
2017-06-09 2:52 ` Andi Kleen
2017-06-09 9:13 ` Milian Wolff
2017-06-11 19:06 ` Andi Kleen
2017-06-08 14:34 ` Arnaldo Carvalho de Melo
2017-05-09 14:36 Andi Kleen
2017-05-09 17:05 ` Jiri Olsa
2017-05-01 19:47 Andi Kleen
2017-05-02 6:41 ` Jiri Olsa
2017-05-04 22:26 ` Andi Kleen
2017-05-05 7:57 ` Jiri Olsa
2017-05-05 19:43 ` Andi Kleen
2017-05-07 14:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509121825.GA9983@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.