From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields
Date: Tue, 9 May 2017 07:34:01 -0700 [thread overview]
Message-ID: <20170509143401.GW22592@two.firstfloor.org> (raw)
In-Reply-To: <20170509134503.GD9983@krava>
On Tue, May 09, 2017 at 03:45:03PM +0200, Jiri Olsa wrote:
> On Tue, May 09, 2017 at 05:29:24AM -0700, Andi Kleen wrote:
> > > so the -F option for 'type:' does not have default set,
> > > and it looks like the +- don't make sense there:
> >
> > hw:+comm is just equivalent to hw:comm
> >
> > Seems fine to me?
> >
> > hw:-comm won't do anything, but I guess that's expected.
> >
> > Don't see any need to change this?
>
> why did you add it in the first place then?
You mean the Don't override defaults check in the hw types specified case?
I guess it could be removed yes.
-Andi
next prev parent reply other threads:[~2017-05-09 14:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 16:21 [PATCH] perf, tools, script: Allow adding and removing fields Andi Kleen
2017-05-09 12:18 ` Jiri Olsa
2017-05-09 12:29 ` Andi Kleen
2017-05-09 13:45 ` Jiri Olsa
2017-05-09 14:34 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-02 15:48 Andi Kleen
2017-06-08 12:59 ` Milian Wolff
2017-06-09 2:52 ` Andi Kleen
2017-06-09 9:13 ` Milian Wolff
2017-06-11 19:06 ` Andi Kleen
2017-06-08 14:34 ` Arnaldo Carvalho de Melo
2017-05-09 14:36 Andi Kleen
2017-05-09 17:05 ` Jiri Olsa
2017-05-01 19:47 Andi Kleen
2017-05-02 6:41 ` Jiri Olsa
2017-05-04 22:26 ` Andi Kleen
2017-05-05 7:57 ` Jiri Olsa
2017-05-05 19:43 ` Andi Kleen
2017-05-07 14:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509143401.GW22592@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.