From: Kees Cook <keescook@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Daniel Micay <danielmicay@gmail.com>,
kexec@lists.infradead.org, Eric Biederman <ebiederm@xmission.com>
Subject: [PATCH] kexec_file: Adjust type of kexec_purgatory
Date: Tue, 9 May 2017 16:06:39 -0700 [thread overview]
Message-ID: <20170509230639.GA132135@beast> (raw)
Defining kexec_purgatory as a zero-length char array upsets compile
time size checking. Since this is entirely runtime sized, switch
this to void *. This silences the warning generated by the future
CONFIG_FORTIFY_SOURCE, which did not like the memcmp() of a "0 byte"
array.
Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
kernel/kexec_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index b118735fea9d..bc86f85f1329 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -30,7 +30,7 @@
* Declare these symbols weak so that if architecture provides a purgatory,
* these will be overridden.
*/
-char __weak kexec_purgatory[0];
+void * __weak kexec_purgatory;
size_t __weak kexec_purgatory_size = 0;
static int kexec_calculate_store_digests(struct kimage *image);
--
2.7.4
--
Kees Cook
Pixel Security
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org, Daniel Micay <danielmicay@gmail.com>
Subject: [PATCH] kexec_file: Adjust type of kexec_purgatory
Date: Tue, 9 May 2017 16:06:39 -0700 [thread overview]
Message-ID: <20170509230639.GA132135@beast> (raw)
Defining kexec_purgatory as a zero-length char array upsets compile
time size checking. Since this is entirely runtime sized, switch
this to void *. This silences the warning generated by the future
CONFIG_FORTIFY_SOURCE, which did not like the memcmp() of a "0 byte"
array.
Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
kernel/kexec_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index b118735fea9d..bc86f85f1329 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -30,7 +30,7 @@
* Declare these symbols weak so that if architecture provides a purgatory,
* these will be overridden.
*/
-char __weak kexec_purgatory[0];
+void * __weak kexec_purgatory;
size_t __weak kexec_purgatory_size = 0;
static int kexec_calculate_store_digests(struct kimage *image);
--
2.7.4
--
Kees Cook
Pixel Security
next reply other threads:[~2017-05-09 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 23:06 Kees Cook [this message]
2017-05-09 23:06 ` [PATCH] kexec_file: Adjust type of kexec_purgatory Kees Cook
2017-05-09 23:13 ` Daniel Micay
2017-05-09 23:13 ` Daniel Micay
2017-05-09 23:22 ` Kees Cook
2017-05-09 23:22 ` Kees Cook
2017-05-10 0:15 ` Eric W. Biederman
2017-05-10 0:15 ` Eric W. Biederman
2017-05-10 19:54 ` Kees Cook
2017-05-10 19:54 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509230639.GA132135@beast \
--to=keescook@chromium.org \
--cc=danielmicay@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.