[PATCH] mm: fix spelling error

[PATCH] mm: fix spelling error

[Copot Alexandru]

Signed-off-by: Copot Alexandru <alex.mihai.c@gmail.com>
---
 mm/vmscan.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index c52b235..8a7c989 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2250,13 +2250,13 @@ static bool shrink_zones(int priority, struct zonelist *zonelist,
 				continue;	/* Let kswapd poll it */
 			if (COMPACTION_BUILD) {
 				/*
-				 * If we already have plenty of memory free for
-				 * compaction in this zone, don't free any more.
-				 * Even though compaction is invoked for any
-				 * non-zero order, only frequent costly order
-				 * reclamation is disruptive enough to become a
-				 * noticable problem, like transparent huge page
-				 * allocations.
+				 * If we already have plenty of memory free
+				 * for compaction in this zone, don't free any
+				 * more.  Even though compaction is invoked
+				 * for any non-zero order, only frequent
+				 * costly order reclamation is disruptive
+				 * enough to become a noticeable problem, like
+				 * transparent huge page allocations.
 				 */
 				if (compaction_ready(zone, sc)) {
 					aborted_reclaim = true;
-- 
1.7.6.3

Re: [PATCH] mm: fix spelling error

[Andrew Morton]

On Sat,  3 Mar 2012 16:13:16 +0200
Copot Alexandru <alex.mihai.c@gmail.com> wrote:

> Signed-off-by: Copot Alexandru <alex.mihai.c@gmail.com>
> ---
>  mm/vmscan.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index c52b235..8a7c989 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2250,13 +2250,13 @@ static bool shrink_zones(int priority, struct zonelist *zonelist,
>  				continue;	/* Let kswapd poll it */
>  			if (COMPACTION_BUILD) {
>  				/*
> -				 * If we already have plenty of memory free for
> -				 * compaction in this zone, don't free any more.
> -				 * Even though compaction is invoked for any
> -				 * non-zero order, only frequent costly order
> -				 * reclamation is disruptive enough to become a
> -				 * noticable problem, like transparent huge page
> -				 * allocations.
> +				 * If we already have plenty of memory free
> +				 * for compaction in this zone, don't free any
> +				 * more.  Even though compaction is invoked
> +				 * for any non-zero order, only frequent
> +				 * costly order reclamation is disruptive
> +				 * enough to become a noticeable problem, like
> +				 * transparent huge page allocations.
>  				 */
>  				if (compaction_ready(zone, sc)) {
>  					aborted_reclaim = true;

hm, you appear to have reformatted the comment to fit into 78 column or
something.  We have 80 to use!

AFACIT the sole spelling mistake was s/noticable/noticeable/.

More significantly, the comment is hard to follow.  Perhaps removing
the "only" wold fix it up.

[PATCH] mm: fix spelling error

[Hao Lee]

Fix variable name error in comments. No code changes.

Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
 include/linux/gfp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index db373b9..ff3d651 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -297,8 +297,8 @@ static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)
 
 /*
  * GFP_ZONE_TABLE is a word size bitstring that is used for looking up the
- * zone to use given the lowest 4 bits of gfp_t. Entries are ZONE_SHIFT long
- * and there are 16 of them to cover all possible combinations of
+ * zone to use given the lowest 4 bits of gfp_t. Entries are GFP_ZONES_SHIFT
+ * bits long and there are 16 of them to cover all possible combinations of
  * __GFP_DMA, __GFP_DMA32, __GFP_MOVABLE and __GFP_HIGHMEM.
  *
  * The zone fallback order is MOVABLE=>HIGHMEM=>NORMAL=>DMA32=>DMA.
-- 
2.9.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH] mm: fix spelling error

[Hao Lee]

Fix variable name error in comments. No code changes.

Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
 include/linux/gfp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index db373b9..ff3d651 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -297,8 +297,8 @@ static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)
 
 /*
  * GFP_ZONE_TABLE is a word size bitstring that is used for looking up the
- * zone to use given the lowest 4 bits of gfp_t. Entries are ZONE_SHIFT long
- * and there are 16 of them to cover all possible combinations of
+ * zone to use given the lowest 4 bits of gfp_t. Entries are GFP_ZONES_SHIFT
+ * bits long and there are 16 of them to cover all possible combinations of
  * __GFP_DMA, __GFP_DMA32, __GFP_MOVABLE and __GFP_HIGHMEM.
  *
  * The zone fallback order is MOVABLE=>HIGHMEM=>NORMAL=>DMA32=>DMA.
-- 
2.9.3

Re: [PATCH] mm: fix spelling error

[Wei Yang]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Tue, Apr 04, 2017 at 12:16:55AM +0800, Hao Lee wrote:
>Fix variable name error in comments. No code changes.
>
>Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
>---
> include/linux/gfp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/include/linux/gfp.h b/include/linux/gfp.h
>index db373b9..ff3d651 100644
>--- a/include/linux/gfp.h
>+++ b/include/linux/gfp.h
>@@ -297,8 +297,8 @@ static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)
> 
> /*
>  * GFP_ZONE_TABLE is a word size bitstring that is used for looking up the
>- * zone to use given the lowest 4 bits of gfp_t. Entries are ZONE_SHIFT long
>- * and there are 16 of them to cover all possible combinations of
>+ * zone to use given the lowest 4 bits of gfp_t. Entries are GFP_ZONES_SHIFT
>+ * bits long and there are 16 of them to cover all possible combinations of
>  * __GFP_DMA, __GFP_DMA32, __GFP_MOVABLE and __GFP_HIGHMEM.
>  *
>  * The zone fallback order is MOVABLE=>HIGHMEM=>NORMAL=>DMA32=>DMA.

Looks good to me.

Acked-by: Wei Yang <richard.weiyang@gmail.com>

>-- 
>2.9.3

-- 
Wei Yang
Help you, Help me

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]