* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-06 5:30 ` Oleksij Rempel 0 siblings, 0 replies; 14+ messages in thread From: Oleksij Rempel @ 2017-05-06 5:30 UTC (permalink / raw) To: linux-arm-kernel This names the GPIO lines on the Banana Pi board in accordance with the A20_Banana_Pi v1.4 Specification. This will make these line names reflect through to user space so that they can easily be identified and used with the new character device ABI. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: devicetree at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org Cc: Chen-Yu Tsai <wens@csie.org> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index 91f2e5f..6b326b3 100644 --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts @@ -178,6 +178,57 @@ }; &pio { + gpio-line-names = + /* PA */ + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3", + "ETXD2", "ETXD1", "ETXD0", + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO", + "ETXEN", "ETXCK", "ECRS", + "ECOL", "ETXERR", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PB */ + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "", + "", "USB0-DRV", "", "", "", "", "", "", + "", "", "", "", "SCL", "SDA", "", "", + "", "", "", "", "", "", "", "", + /* PC */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PD */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PE */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PF */ + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", + "SD0-D2", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PG */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PH */ + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", + "", "", "SD0-DET", "", "", "", "", "", + "", "", "", "", "IO-4", "IO-5", "", "EMAC-PWR-EN", + "LED1", "", "", "", "", "", "", "", + /* PI */ + "", "", "", "IO-GCLK", "", "", "", "", + "", "", "SPI-CE0", "SPI-CLK", "SPI-MOSI", + "SPI-MISO", "SPI-CE1", "", + "IO-6", "IO-3", "IO-2", "IO-0", "", "", "", "", + "", "", "", "", "", "", "", ""; + usb0_id_detect_pin: usb0_id_detect_pin at 0 { pins = "PH4"; function = "gpio_in"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-06 5:30 ` Oleksij Rempel 0 siblings, 0 replies; 14+ messages in thread From: Oleksij Rempel @ 2017-05-06 5:30 UTC (permalink / raw) To: ore-bIcnvbaLZ9MEGnE8C9+IrQ Cc: Oleksij Rempel, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai, Maxime Ripard This names the GPIO lines on the Banana Pi board in accordance with the A20_Banana_Pi v1.4 Specification. This will make these line names reflect through to user space so that they can easily be identified and used with the new character device ABI. Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index 91f2e5f..6b326b3 100644 --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts @@ -178,6 +178,57 @@ }; &pio { + gpio-line-names = + /* PA */ + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3", + "ETXD2", "ETXD1", "ETXD0", + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO", + "ETXEN", "ETXCK", "ECRS", + "ECOL", "ETXERR", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PB */ + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "", + "", "USB0-DRV", "", "", "", "", "", "", + "", "", "", "", "SCL", "SDA", "", "", + "", "", "", "", "", "", "", "", + /* PC */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PD */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PE */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PF */ + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", + "SD0-D2", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PG */ + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + /* PH */ + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", + "", "", "SD0-DET", "", "", "", "", "", + "", "", "", "", "IO-4", "IO-5", "", "EMAC-PWR-EN", + "LED1", "", "", "", "", "", "", "", + /* PI */ + "", "", "", "IO-GCLK", "", "", "", "", + "", "", "SPI-CE0", "SPI-CLK", "SPI-MOSI", + "SPI-MISO", "SPI-CE1", "", + "IO-6", "IO-3", "IO-2", "IO-0", "", "", "", "", + "", "", "", "", "", "", "", ""; + usb0_id_detect_pin: usb0_id_detect_pin@0 { pins = "PH4"; function = "gpio_in"; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines 2017-05-06 5:30 ` Oleksij Rempel @ 2017-05-07 7:41 ` Linus Walleij -1 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2017-05-07 7:41 UTC (permalink / raw) To: linux-arm-kernel On Sat, May 6, 2017 at 7:30 AM, Oleksij Rempel <linux@rempel-privat.de> wrote: > This names the GPIO lines on the Banana Pi board in accordance with > the A20_Banana_Pi v1.4 Specification. > > This will make these line names reflect through to user space > so that they can easily be identified and used with the new > character device ABI. > > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: devicetree at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-07 7:41 ` Linus Walleij 0 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2017-05-07 7:41 UTC (permalink / raw) To: Oleksij Rempel Cc: devicetree@vger.kernel.org, Chen-Yu Tsai, ore, Maxime Ripard, linux-arm-kernel@lists.infradead.org On Sat, May 6, 2017 at 7:30 AM, Oleksij Rempel <linux@rempel-privat.de> wrote: > This names the GPIO lines on the Banana Pi board in accordance with > the A20_Banana_Pi v1.4 Specification. > > This will make these line names reflect through to user space > so that they can easily be identified and used with the new > character device ABI. > > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-09 20:27 ` Maxime Ripard 0 siblings, 0 replies; 14+ messages in thread From: Maxime Ripard @ 2017-05-09 20:27 UTC (permalink / raw) To: linux-arm-kernel Hi Oleksij, It looks much better, thanks! On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote: > This names the GPIO lines on the Banana Pi board in accordance with > the A20_Banana_Pi v1.4 Specification. > > This will make these line names reflect through to user space > so that they can easily be identified and used with the new > character device ABI. > > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: devicetree at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > --- Usually, it's better here if you put a change log with the things that changed from one version to another. You probably remember all of the comments that were made on the previous version of that patch, but I don't ;) > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > index 91f2e5f..6b326b3 100644 > --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > @@ -178,6 +178,57 @@ > }; > > &pio { > + gpio-line-names = > + /* PA */ > + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3", > + "ETXD2", "ETXD1", "ETXD0", > + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO", > + "ETXEN", "ETXCK", "ECRS", > + "ECOL", "ETXERR", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PB */ > + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "", > + "", "USB0-DRV", "", "", "", "", "", "", > + "", "", "", "", "SCL", "SDA", "", "", I'm not sure how it's called in the schematics / documentation, but having a way to get which bus it's from would be helpful (like you did for the PMIC I2C bus). > + "", "", "", "", "", "", "", "", > + /* PC */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PD */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PE */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PF */ > + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", > + "SD0-D2", "", "", Why did you change the wrapping and indentation on those two lines? > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PG */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PH */ > + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", What are PH3 and PH5 used for on the board? Can't we provide a more explicit name? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170509/5105599d/attachment-0001.sig> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-09 20:27 ` Maxime Ripard 0 siblings, 0 replies; 14+ messages in thread From: Maxime Ripard @ 2017-05-09 20:27 UTC (permalink / raw) To: Oleksij Rempel Cc: ore-bIcnvbaLZ9MEGnE8C9+IrQ, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai [-- Attachment #1: Type: text/plain, Size: 3358 bytes --] Hi Oleksij, It looks much better, thanks! On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote: > This names the GPIO lines on the Banana Pi board in accordance with > the A20_Banana_Pi v1.4 Specification. > > This will make these line names reflect through to user space > so that they can easily be identified and used with the new > character device ABI. > > Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org> > Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > --- Usually, it's better here if you put a change log with the things that changed from one version to another. You probably remember all of the comments that were made on the previous version of that patch, but I don't ;) > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > index 91f2e5f..6b326b3 100644 > --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > @@ -178,6 +178,57 @@ > }; > > &pio { > + gpio-line-names = > + /* PA */ > + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3", > + "ETXD2", "ETXD1", "ETXD0", > + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO", > + "ETXEN", "ETXCK", "ECRS", > + "ECOL", "ETXERR", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PB */ > + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "", > + "", "USB0-DRV", "", "", "", "", "", "", > + "", "", "", "", "SCL", "SDA", "", "", I'm not sure how it's called in the schematics / documentation, but having a way to get which bus it's from would be helpful (like you did for the PMIC I2C bus). > + "", "", "", "", "", "", "", "", > + /* PC */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PD */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PE */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PF */ > + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", > + "SD0-D2", "", "", Why did you change the wrapping and indentation on those two lines? > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PG */ > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + /* PH */ > + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", What are PH3 and PH5 used for on the board? Can't we provide a more explicit name? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines 2017-05-09 20:27 ` Maxime Ripard @ 2017-05-10 4:47 ` Oleksij Rempel -1 siblings, 0 replies; 14+ messages in thread From: Oleksij Rempel @ 2017-05-10 4:47 UTC (permalink / raw) To: linux-arm-kernel Am 09.05.2017 um 22:27 schrieb Maxime Ripard: > Hi Oleksij, > > It looks much better, thanks! > > On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote: >> This names the GPIO lines on the Banana Pi board in accordance with >> the A20_Banana_Pi v1.4 Specification. >> >> This will make these line names reflect through to user space >> so that they can easily be identified and used with the new >> character device ABI. >> >> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: devicetree at vger.kernel.org >> Cc: linux-arm-kernel at lists.infradead.org >> Cc: Chen-Yu Tsai <wens@csie.org> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >> --- > > Usually, it's better here if you put a change log with the things that > changed from one version to another. > > You probably remember all of the comments that were made on the > previous version of that patch, but I don't ;) ok. > >> arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> index 91f2e5f..6b326b3 100644 >> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> @@ -178,6 +178,57 @@ >> }; >> >> &pio { >> + gpio-line-names = >> + /* PA */ >> + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3", >> + "ETXD2", "ETXD1", "ETXD0", >> + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO", >> + "ETXEN", "ETXCK", "ECRS", >> + "ECOL", "ETXERR", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PB */ >> + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "", >> + "", "USB0-DRV", "", "", "", "", "", "", >> + "", "", "", "", "SCL", "SDA", "", "", > > I'm not sure how it's called in the schematics / documentation, but > having a way to get which bus it's from would be helpful (like you did > for the PMIC I2C bus). I use only names provided by schematics. Using something different IMO makes no sense and confusing. >> + "", "", "", "", "", "", "", "", >> + /* PC */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PD */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PE */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PF */ >> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", >> + "SD0-D2", "", "", > > Why did you change the wrapping and indentation on those two lines? i use 8 entry per line to keep counting easier. If line is too wide, i wrap it with changed indentation. >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PG */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PH */ >> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", > > What are PH3 and PH5 used for on the board? Can't we provide a more > explicit name? Only names used by schematic :) If we will use something different users will hate us even more. I can image to use some kind of combination of connector name and pin name. For example: "JP1-RXD0", or some thing like this. > Thanks! > Maxime > -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170510/ef46205f/attachment.sig> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-10 4:47 ` Oleksij Rempel 0 siblings, 0 replies; 14+ messages in thread From: Oleksij Rempel @ 2017-05-10 4:47 UTC (permalink / raw) To: Maxime Ripard Cc: ore-bIcnvbaLZ9MEGnE8C9+IrQ, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai [-- Attachment #1.1: Type: text/plain, Size: 3900 bytes --] Am 09.05.2017 um 22:27 schrieb Maxime Ripard: > Hi Oleksij, > > It looks much better, thanks! > > On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote: >> This names the GPIO lines on the Banana Pi board in accordance with >> the A20_Banana_Pi v1.4 Specification. >> >> This will make these line names reflect through to user space >> so that they can easily be identified and used with the new >> character device ABI. >> >> Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org> >> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >> Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> >> Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> >> --- > > Usually, it's better here if you put a change log with the things that > changed from one version to another. > > You probably remember all of the comments that were made on the > previous version of that patch, but I don't ;) ok. > >> arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> index 91f2e5f..6b326b3 100644 >> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> @@ -178,6 +178,57 @@ >> }; >> >> &pio { >> + gpio-line-names = >> + /* PA */ >> + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3", >> + "ETXD2", "ETXD1", "ETXD0", >> + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO", >> + "ETXEN", "ETXCK", "ECRS", >> + "ECOL", "ETXERR", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PB */ >> + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "", >> + "", "USB0-DRV", "", "", "", "", "", "", >> + "", "", "", "", "SCL", "SDA", "", "", > > I'm not sure how it's called in the schematics / documentation, but > having a way to get which bus it's from would be helpful (like you did > for the PMIC I2C bus). I use only names provided by schematics. Using something different IMO makes no sense and confusing. >> + "", "", "", "", "", "", "", "", >> + /* PC */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PD */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PE */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PF */ >> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", >> + "SD0-D2", "", "", > > Why did you change the wrapping and indentation on those two lines? i use 8 entry per line to keep counting easier. If line is too wide, i wrap it with changed indentation. >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PG */ >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + "", "", "", "", "", "", "", "", >> + /* PH */ >> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", > > What are PH3 and PH5 used for on the board? Can't we provide a more > explicit name? Only names used by schematic :) If we will use something different users will hate us even more. I can image to use some kind of combination of connector name and pin name. For example: "JP1-RXD0", or some thing like this. > Thanks! > Maxime > -- Regards, Oleksij [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-10 12:47 ` Maxime Ripard 0 siblings, 0 replies; 14+ messages in thread From: Maxime Ripard @ 2017-05-10 12:47 UTC (permalink / raw) To: linux-arm-kernel On Wed, May 10, 2017 at 06:47:58AM +0200, Oleksij Rempel wrote: > >> + "", "", "", "", "SCL", "SDA", "", "", > > > > I'm not sure how it's called in the schematics / documentation, but > > having a way to get which bus it's from would be helpful (like you did > > for the PMIC I2C bus). > > I use only names provided by schematics. Using something different IMO > makes no sense and confusing. Indeed. > >> + "", "", "", "", "", "", "", "", > >> + /* PC */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PD */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PE */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PF */ > >> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", > >> + "SD0-D2", "", "", > > > > Why did you change the wrapping and indentation on those two lines? > > i use 8 entry per line to keep counting easier. If line is too wide, i > wrap it with changed indentation. Ack. > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PG */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PH */ > >> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", > > > > What are PH3 and PH5 used for on the board? Can't we provide a more > > explicit name? > > Only names used by schematic :) If we will use something different users > will hate us even more. Those schematics suck then :) > I can image to use some kind of combination of connector name and pin > name. For example: "JP1-RXD0", or some thing like this. There's no mark on the PCB either? RXD0 and the other are fine, the only ones that concern me are PH3 and PH5, which are basically only the SoC pin name, and nothing else. I guess we don't really have the choice if the schematic uses that, and there's nothing on the PCB.. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170510/beb3fdb2/attachment.sig> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-10 12:47 ` Maxime Ripard 0 siblings, 0 replies; 14+ messages in thread From: Maxime Ripard @ 2017-05-10 12:47 UTC (permalink / raw) To: Oleksij Rempel Cc: ore-bIcnvbaLZ9MEGnE8C9+IrQ, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai [-- Attachment #1: Type: text/plain, Size: 2478 bytes --] On Wed, May 10, 2017 at 06:47:58AM +0200, Oleksij Rempel wrote: > >> + "", "", "", "", "SCL", "SDA", "", "", > > > > I'm not sure how it's called in the schematics / documentation, but > > having a way to get which bus it's from would be helpful (like you did > > for the PMIC I2C bus). > > I use only names provided by schematics. Using something different IMO > makes no sense and confusing. Indeed. > >> + "", "", "", "", "", "", "", "", > >> + /* PC */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PD */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PE */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PF */ > >> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", > >> + "SD0-D2", "", "", > > > > Why did you change the wrapping and indentation on those two lines? > > i use 8 entry per line to keep counting easier. If line is too wide, i > wrap it with changed indentation. Ack. > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PG */ > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + "", "", "", "", "", "", "", "", > >> + /* PH */ > >> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", > > > > What are PH3 and PH5 used for on the board? Can't we provide a more > > explicit name? > > Only names used by schematic :) If we will use something different users > will hate us even more. Those schematics suck then :) > I can image to use some kind of combination of connector name and pin > name. For example: "JP1-RXD0", or some thing like this. There's no mark on the PCB either? RXD0 and the other are fine, the only ones that concern me are PH3 and PH5, which are basically only the SoC pin name, and nothing else. I guess we don't really have the choice if the schematic uses that, and there's nothing on the PCB.. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines 2017-05-10 12:47 ` Maxime Ripard @ 2017-05-10 14:27 ` Oleksij Rempel -1 siblings, 0 replies; 14+ messages in thread From: Oleksij Rempel @ 2017-05-10 14:27 UTC (permalink / raw) To: linux-arm-kernel Am 10.05.2017 um 14:47 schrieb Maxime Ripard: > On Wed, May 10, 2017 at 06:47:58AM +0200, Oleksij Rempel wrote: >>>> + "", "", "", "", "SCL", "SDA", "", "", >>> >>> I'm not sure how it's called in the schematics / documentation, but >>> having a way to get which bus it's from would be helpful (like you did >>> for the PMIC I2C bus). >> >> I use only names provided by schematics. Using something different IMO >> makes no sense and confusing. > > Indeed. > >>>> + "", "", "", "", "", "", "", "", >>>> + /* PC */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PD */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PE */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PF */ >>>> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", >>>> + "SD0-D2", "", "", >>> >>> Why did you change the wrapping and indentation on those two lines? >> >> i use 8 entry per line to keep counting easier. If line is too wide, i >> wrap it with changed indentation. > > Ack. > >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PG */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PH */ >>>> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", >>> >>> What are PH3 and PH5 used for on the board? Can't we provide a more >>> explicit name? >> >> Only names used by schematic :) If we will use something different users >> will hate us even more. > > Those schematics suck then :) > >> I can image to use some kind of combination of connector name and pin >> name. For example: "JP1-RXD0", or some thing like this. > > There's no mark on the PCB either? correct, no mark on the PCB. > RXD0 and the other are fine, the > only ones that concern me are PH3 and PH5, which are basically only > the SoC pin name, and nothing else. > > I guess we don't really have the choice if the schematic uses that, > and there's nothing on the PCB.. ack. -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170510/8e922cbf/attachment.sig> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-10 14:27 ` Oleksij Rempel 0 siblings, 0 replies; 14+ messages in thread From: Oleksij Rempel @ 2017-05-10 14:27 UTC (permalink / raw) To: Maxime Ripard Cc: devicetree, Linus Walleij, ore, Chen-Yu Tsai, linux-arm-kernel [-- Attachment #1.1.1: Type: text/plain, Size: 2523 bytes --] Am 10.05.2017 um 14:47 schrieb Maxime Ripard: > On Wed, May 10, 2017 at 06:47:58AM +0200, Oleksij Rempel wrote: >>>> + "", "", "", "", "SCL", "SDA", "", "", >>> >>> I'm not sure how it's called in the schematics / documentation, but >>> having a way to get which bus it's from would be helpful (like you did >>> for the PMIC I2C bus). >> >> I use only names provided by schematics. Using something different IMO >> makes no sense and confusing. > > Indeed. > >>>> + "", "", "", "", "", "", "", "", >>>> + /* PC */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PD */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PE */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PF */ >>>> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3", >>>> + "SD0-D2", "", "", >>> >>> Why did you change the wrapping and indentation on those two lines? >> >> i use 8 entry per line to keep counting easier. If line is too wide, i >> wrap it with changed indentation. > > Ack. > >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PG */ >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + "", "", "", "", "", "", "", "", >>>> + /* PH */ >>>> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "", >>> >>> What are PH3 and PH5 used for on the board? Can't we provide a more >>> explicit name? >> >> Only names used by schematic :) If we will use something different users >> will hate us even more. > > Those schematics suck then :) > >> I can image to use some kind of combination of connector name and pin >> name. For example: "JP1-RXD0", or some thing like this. > > There's no mark on the PCB either? correct, no mark on the PCB. > RXD0 and the other are fine, the > only ones that concern me are PH3 and PH5, which are basically only > the SoC pin name, and nothing else. > > I guess we don't really have the choice if the schematic uses that, > and there's nothing on the PCB.. ack. -- Regards, Oleksij [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 213 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-10 14:54 ` Maxime Ripard 0 siblings, 0 replies; 14+ messages in thread From: Maxime Ripard @ 2017-05-10 14:54 UTC (permalink / raw) To: linux-arm-kernel On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote: > This names the GPIO lines on the Banana Pi board in accordance with > the A20_Banana_Pi v1.4 Specification. > > This will make these line names reflect through to user space > so that they can easily be identified and used with the new > character device ABI. Merged, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170510/1c927dc8/attachment.sig> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines @ 2017-05-10 14:54 ` Maxime Ripard 0 siblings, 0 replies; 14+ messages in thread From: Maxime Ripard @ 2017-05-10 14:54 UTC (permalink / raw) To: Oleksij Rempel Cc: ore-bIcnvbaLZ9MEGnE8C9+IrQ, Linus Walleij, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai [-- Attachment #1: Type: text/plain, Size: 465 bytes --] On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote: > This names the GPIO lines on the Banana Pi board in accordance with > the A20_Banana_Pi v1.4 Specification. > > This will make these line names reflect through to user space > so that they can easily be identified and used with the new > character device ABI. Merged, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-05-10 14:54 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-05-06 5:30 [PATCH v3] arm: dts: sun7i-a20-bananapi: name the GPIO lines Oleksij Rempel 2017-05-06 5:30 ` Oleksij Rempel 2017-05-07 7:41 ` Linus Walleij 2017-05-07 7:41 ` Linus Walleij 2017-05-09 20:27 ` Maxime Ripard 2017-05-09 20:27 ` Maxime Ripard 2017-05-10 4:47 ` Oleksij Rempel 2017-05-10 4:47 ` Oleksij Rempel 2017-05-10 12:47 ` Maxime Ripard 2017-05-10 12:47 ` Maxime Ripard 2017-05-10 14:27 ` Oleksij Rempel 2017-05-10 14:27 ` Oleksij Rempel 2017-05-10 14:54 ` Maxime Ripard 2017-05-10 14:54 ` Maxime Ripard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.