Re: [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disabled

[Peter Xu <peterx@redhat.com>]

On Thu, May 11, 2017 at 09:48:52AM +0200, Paolo Bonzini wrote:
> 
> 
> On 11/05/2017 04:56, Peter Xu wrote:
> >> @@ -3510,12 +3511,16 @@ static void kvm_update_msi_routes_all(void *private, bool global,
> >>      int cnt = 0;
> >>      MSIRouteEntry *entry;
> >>      MSIMessage msg;
> >> +    PCIDevice *dev;
> >> +
> >>      /* TODO: explicit route update */
> >>      QLIST_FOREACH(entry, &msi_route_list, list) {
> >> -        cnt++;
> > 
> > Oops, I think this line should be kept. It does not affect too much,
> > only the trace below. But still, no reason to remove it.
> > 
> > Paolo, would it still possible to touch it up in your queue?
> 
> Yup, fixed.

That's great. Thanks!

-- 
Peter Xu