From: Stephen Hemminger <stephen@networkplumber.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()
Date: Thu, 11 May 2017 16:42:27 +0000 [thread overview]
Message-ID: <20170511094227.22202648@xeon-e3> (raw)
In-Reply-To: <2182bf8e-b48a-d3bb-6f26-d4af8c4f1507@users.sourceforge.net>
On Thu, 11 May 2017 18:36:44 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> > Taking out the message assumes that all callers of this function either log an
> > error or pass appropriate error code back to userspace.
>
> Do you like the default error response by Linux memory allocation functions?
The default error message only helps a little.
I doubt this will ever fail anyway since only allocated on boot.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()
Date: Thu, 11 May 2017 09:42:27 -0700 [thread overview]
Message-ID: <20170511094227.22202648@xeon-e3> (raw)
In-Reply-To: <2182bf8e-b48a-d3bb-6f26-d4af8c4f1507@users.sourceforge.net>
On Thu, 11 May 2017 18:36:44 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> > Taking out the message assumes that all callers of this function either log an
> > error or pass appropriate error code back to userspace.
>
> Do you like the default error response by Linux memory allocation functions?
The default error message only helps a little.
I doubt this will ever fail anyway since only allocated on boot.
next prev parent reply other threads:[~2017-05-11 16:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 16:14 [PATCH 0/4] VMBus: Adjustments for some function implementations SF Markus Elfring
2017-05-11 16:14 ` SF Markus Elfring
2017-05-11 16:15 ` [PATCH 1/4] vmbus: Improve a size determination in vmbus_device_create() SF Markus Elfring
2017-05-11 16:15 ` SF Markus Elfring
2017-05-11 16:30 ` Stephen Hemminger
2017-05-11 16:30 ` Stephen Hemminger
2017-05-11 17:47 ` Greg KH
2017-05-11 17:47 ` Greg KH
2017-05-11 16:17 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-11 16:17 ` SF Markus Elfring
2017-05-11 16:30 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Stephen Hemminger
2017-05-11 16:30 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() Stephen Hemminger
2017-05-11 16:36 ` SF Markus Elfring
2017-05-11 16:36 ` SF Markus Elfring
2017-05-11 16:42 ` Stephen Hemminger [this message]
2017-05-11 16:42 ` Stephen Hemminger
2017-05-12 7:09 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Dan Carpenter
2017-05-12 7:09 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() Dan Carpenter
2017-05-12 7:32 ` SF Markus Elfring
2017-05-12 7:32 ` SF Markus Elfring
2017-05-12 7:52 ` Joe Perches
2017-05-12 7:52 ` Joe Perches
2017-05-12 8:23 ` Clarification for general change acceptance SF Markus Elfring
2017-05-12 8:23 ` SF Markus Elfring
2017-05-12 8:37 ` Julia Lawall
2017-05-12 8:37 ` Julia Lawall
2017-05-12 8:45 ` SF Markus Elfring
2017-05-12 8:45 ` SF Markus Elfring
2017-05-11 16:18 ` [PATCH 3/4] vmbus: Fix a typo in a comment line SF Markus Elfring
2017-05-11 16:18 ` SF Markus Elfring
2017-05-11 16:33 ` Stephen Hemminger
2017-05-11 16:33 ` Stephen Hemminger
2017-05-11 16:19 ` [PATCH 4/4] vmbus: Adjust five checks for null pointers SF Markus Elfring
2017-05-11 16:19 ` SF Markus Elfring
2017-05-11 16:34 ` Stephen Hemminger
2017-05-11 16:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511094227.22202648@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=devel@linuxdriverproject.org \
--cc=elfring@users.sourceforge.net \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.