From: Al Viro <viro@ZenIV.linux.org.uk>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Richard Henderson <rth@twiddle.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] alpha-module: Improve a size determination in module_frob_arch_sections()
Date: Fri, 12 May 2017 05:04:40 +0000 [thread overview]
Message-ID: <20170512050440.GO390@ZenIV.linux.org.uk> (raw)
In-Reply-To: <7e1572c7-8c8e-7b1b-ae56-cbdf1ad23fbc@users.sourceforge.net>
On Thu, May 11, 2017 at 01:54:42PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 11 May 2017 12:54:29 +0200
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
It's also making it harder to grep for. For the record: any patches of
that sort in VFS will be dropped. Preferably - on their author's toes,
after forcing said author to engrave them on bricks. Ideally - lead ones...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Richard Henderson <rth@twiddle.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] alpha-module: Improve a size determination in module_frob_arch_sections()
Date: Fri, 12 May 2017 06:04:40 +0100 [thread overview]
Message-ID: <20170512050440.GO390@ZenIV.linux.org.uk> (raw)
In-Reply-To: <7e1572c7-8c8e-7b1b-ae56-cbdf1ad23fbc@users.sourceforge.net>
On Thu, May 11, 2017 at 01:54:42PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 11 May 2017 12:54:29 +0200
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
It's also making it harder to grep for. For the record: any patches of
that sort in VFS will be dropped. Preferably - on their author's toes,
after forcing said author to engrave them on bricks. Ideally - lead ones...
next prev parent reply other threads:[~2017-05-12 5:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 11:53 [PATCH 0/2] alpha-module: Adjustments for module_frob_arch_sections() SF Markus Elfring
2017-05-11 11:53 ` SF Markus Elfring
2017-05-11 11:54 ` [PATCH 1/2] alpha-module: Improve a size determination in module_frob_arch_sections() SF Markus Elfring
2017-05-11 11:54 ` SF Markus Elfring
2017-05-12 5:04 ` Al Viro [this message]
2017-05-12 5:04 ` Al Viro
2017-05-11 11:55 ` [PATCH 2/2] alpha-module: Delete an error message for a failed memory allocation in module_frob_arch SF Markus Elfring
2017-05-11 11:55 ` [PATCH 2/2] alpha-module: Delete an error message for a failed memory allocation in module_frob_arch_sections() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512050440.GO390@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=elfring@users.sourceforge.net \
--cc=ink@jurassic.park.msu.ru \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.