From: "Michael S. Tsirkin" <mst@redhat.com>
To: Maciek Fijalkowski <macfij7@wp.pl>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 3/3] Fix ERROR: code indent should use tabs where possible
Date: Mon, 15 May 2017 06:00:38 +0300 [thread overview]
Message-ID: <20170515055845-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170514175130.18664-3-macfij7@wp.pl>
On Sun, May 14, 2017 at 07:51:30PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7@wp.pl>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
But you really want to fix the subject. Make it less verbose
drop upper case and add info about module. Something like:
virtio_net: coding style fix: use tabs for indent
Also, you misspelled Jason's email.
> ---
> drivers/net/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 6c8170c..5d71e9f 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2717,7 +2717,7 @@ static __init int virtio_net_driver_init(void)
> if (ret)
> goto err_dead;
>
> - ret = register_virtio_driver(&virtio_net_driver);
> + ret = register_virtio_driver(&virtio_net_driver);
> if (ret)
> goto err_virtio;
> return 0;
> --
> 2.4.11
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Maciek Fijalkowski <macfij7@wp.pl>
Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Fix ERROR: code indent should use tabs where possible
Date: Mon, 15 May 2017 06:00:38 +0300 [thread overview]
Message-ID: <20170515055845-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170514175130.18664-3-macfij7@wp.pl>
On Sun, May 14, 2017 at 07:51:30PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7@wp.pl>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
But you really want to fix the subject. Make it less verbose
drop upper case and add info about module. Something like:
virtio_net: coding style fix: use tabs for indent
Also, you misspelled Jason's email.
> ---
> drivers/net/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 6c8170c..5d71e9f 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2717,7 +2717,7 @@ static __init int virtio_net_driver_init(void)
> if (ret)
> goto err_dead;
>
> - ret = register_virtio_driver(&virtio_net_driver);
> + ret = register_virtio_driver(&virtio_net_driver);
> if (ret)
> goto err_virtio;
> return 0;
> --
> 2.4.11
next prev parent reply other threads:[~2017-05-15 3:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 17:51 [PATCH 1/3] Fix ERROR: trailing statements should be on next line Maciek Fijalkowski
2017-05-14 17:51 ` [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses Maciek Fijalkowski
2017-05-14 17:51 ` Maciek Fijalkowski
2017-05-14 18:48 ` kbuild test robot
2017-05-14 18:48 ` kbuild test robot
2017-05-14 18:48 ` kbuild test robot
2017-05-15 0:25 ` Andrew Lunn
2017-05-15 0:25 ` Andrew Lunn
2017-05-15 2:56 ` Michael S. Tsirkin
2017-05-15 2:56 ` Michael S. Tsirkin
2017-05-14 17:51 ` [PATCH 3/3] Fix ERROR: code indent should use tabs where possible Maciek Fijalkowski
2017-05-14 17:51 ` Maciek Fijalkowski
2017-05-15 3:00 ` Michael S. Tsirkin [this message]
2017-05-15 3:00 ` Michael S. Tsirkin
2017-05-15 2:58 ` [PATCH 1/3] Fix ERROR: trailing statements should be on next line Michael S. Tsirkin
2017-05-15 2:58 ` Michael S. Tsirkin
2017-05-15 3:20 ` Alex Williamson
2017-05-15 3:20 ` Alex Williamson
2017-05-15 14:25 ` David Laight
2017-05-15 14:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515055845-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macfij7@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.