* [PATCH] gpu: host1x: Forbid RESTART opcode in the firewall
@ 2017-05-15 12:02 Dmitry Osipenko
2017-05-15 12:06 ` Erik Faye-Lund
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2017-05-15 12:02 UTC (permalink / raw)
To: Thierry Reding, Mikko Perttunen
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, DRI Development,
Erik Faye-Lund
The RESTART opcode terminates the gather and restarts the CDMA fetch from
a specified word << 2 relative to the CDMA start address. That shouldn't
be allowed to be done by userspace.
Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/gpu/host1x/job.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
index 8f0d43b8f9a6..d648748b3e74 100644
--- a/drivers/gpu/host1x/job.c
+++ b/drivers/gpu/host1x/job.c
@@ -493,7 +493,6 @@ static int validate(struct host1x_firewall *fw, struct host1x_job_gather *g)
goto out;
break;
case 4:
- case 5:
case 14:
break;
default:
--
2.13.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpu: host1x: Forbid RESTART opcode in the firewall
2017-05-15 12:02 [PATCH] gpu: host1x: Forbid RESTART opcode in the firewall Dmitry Osipenko
@ 2017-05-15 12:06 ` Erik Faye-Lund
0 siblings, 0 replies; 2+ messages in thread
From: Erik Faye-Lund @ 2017-05-15 12:06 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: linux-tegra@vger.kernel.org, Mikko Perttunen, DRI Development
On Mon, May 15, 2017 at 2:02 PM, Dmitry Osipenko <digetx@gmail.com> wrote:
> The RESTART opcode terminates the gather and restarts the CDMA fetch from
> a specified word << 2 relative to the CDMA start address. That shouldn't
> be allowed to be done by userspace.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Outch, yeah.
Reviewed-by: Erik Faye-Lund <kusmabite@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-15 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-15 12:02 [PATCH] gpu: host1x: Forbid RESTART opcode in the firewall Dmitry Osipenko
2017-05-15 12:06 ` Erik Faye-Lund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.