* [PATCH] char: ipmi: remove unnecessary code
@ 2017-05-15 20:46 Gustavo A. R. Silva
2017-05-17 13:11 ` Corey Minyard
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-15 20:46 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-kernel, Gustavo A. R. Silva
The array field name in struct i2c_adapter is a fixed size array
so it can never be NULL.
Addresses-Coverity-ID: 1397986
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/char/ipmi/ipmi_ssif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index cca6e5b..df4fea7 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
list_for_each_entry(info, &ssif_infos, link) {
if (info->binfo.addr != client->addr)
continue;
- if (info->adapter_name && client->adapter->name &&
+ if (info->adapter_name &&
strcmp_nospace(info->adapter_name,
client->adapter->name))
continue;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] char: ipmi: remove unnecessary code
2017-05-15 20:46 [PATCH] char: ipmi: remove unnecessary code Gustavo A. R. Silva
@ 2017-05-17 13:11 ` Corey Minyard
2017-05-17 20:54 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Corey Minyard @ 2017-05-17 13:11 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: openipmi-developer, linux-kernel
On 05/15/2017 03:46 PM, Gustavo A. R. Silva wrote:
> The array field name in struct i2c_adapter is a fixed size array
> so it can never be NULL.
This was already caught by Colin Ian King, a patch is already queued for
this.
Thanks,
-corey
> Addresses-Coverity-ID: 1397986
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index cca6e5b..df4fea7 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
> list_for_each_entry(info, &ssif_infos, link) {
> if (info->binfo.addr != client->addr)
> continue;
> - if (info->adapter_name && client->adapter->name &&
> + if (info->adapter_name &&
> strcmp_nospace(info->adapter_name,
> client->adapter->name))
> continue;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] char: ipmi: remove unnecessary code
2017-05-17 13:11 ` Corey Minyard
@ 2017-05-17 20:54 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-17 20:54 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-kernel
Hi Corey,
Quoting Corey Minyard <minyard@acm.org>:
> On 05/15/2017 03:46 PM, Gustavo A. R. Silva wrote:
>> The array field name in struct i2c_adapter is a fixed size array
>> so it can never be NULL.
>
> This was already caught by Colin Ian King, a patch is already queued
> for this.
>
Great, it's good to know.
Thanks
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-17 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-15 20:46 [PATCH] char: ipmi: remove unnecessary code Gustavo A. R. Silva
2017-05-17 13:11 ` Corey Minyard
2017-05-17 20:54 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.