[meta-oe][morty][PATCH 1/1] openssl-native: Compile with -fPIC

[meta-oe][morty][PATCH 1/1] openssl-native: Compile with -fPIC

[Mirza Krak]

From: Khem Raj <raj.khem@gmail.com>

Fixes
| /usr/bin/ld: libcrypto.a(sha1-x86_64.o): relocation R_X86_64_PC32 against undefined symbol `OPENSSL_ia32cap_P' can not be used when making a shared object; recompile with -fPIC
| /usr/bin/ld: final link failed: Bad value

Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 0a19e72081771fca8ed94fb2a2a8996fd3dce00c)
Signed-off-by: Mirza Krak <mirza.krak@endian.se>
---

I hit the same compiler error as in above commit message when running on morty branch. 

I simply cherry-picked that fix in to morty branch. I looked in the git log of oe-core and it seems to me that it shall be ok to do that?

 meta/recipes-connectivity/openssl/openssl_1.0.2j.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb b/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb
index 9a7cdedd05..b6fb126349 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb
@@ -5,6 +5,7 @@ require openssl.inc
 DEPENDS += "cryptodev-linux"
 
 CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
+CFLAG_append_class-native = " -fPIC"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=27ffa5d74bb5a337056c14b2ef93fbf6"
 
-- 
2.12.2

✗ patchtest: failure for [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

[Patchwork]

== Series Details ==

Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
Revision: 1
URL   : https://patchwork.openembedded.org/series/6671/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 1239620182)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: ✗ patchtest: failure for [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

[Mirza Krak]

2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
> == Series Details ==
>
> Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/6671/
> State : failure

I seem to have messed up here.

Why does the testing framework think that I was targeting master? Was
my subject prefix wrong?

-- 
Med Vänliga Hälsningar / Best Regards

Mirza Krak
Senior Embedded Engineer

Endian Technologies AB
Flöjelbergsgatan 11
SE-431 37 Mölndal, Sweden
mobile: +46 730 28 06 22
email: mirza.krak@endian.se
www.endian.se

Re: ✗ patchtest: failure for [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

[Denys Dmytriyenko]

On Mon, May 15, 2017 at 09:05:23AM +0200, Mirza Krak wrote:
> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
> > == Series Details ==
> >
> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
> > Revision: 1
> > URL   : https://patchwork.openembedded.org/series/6671/
> > State : failure
> 
> I seem to have messed up here.
> 
> Why does the testing framework think that I was targeting master? Was
> my subject prefix wrong?

Why is there "meta-oe" in there? This is oe-core, not meta-oe...

-- 
Denys

Re: ✗ patchtest: failure for [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

[Mirza Krak]

2017-05-16 0:10 GMT+02:00 Denys Dmytriyenko <denis@denix.org>:
> On Mon, May 15, 2017 at 09:05:23AM +0200, Mirza Krak wrote:
>> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
>> > == Series Details ==
>> >
>> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
>> > Revision: 1
>> > URL   : https://patchwork.openembedded.org/series/6671/
>> > State : failure
>>
>> I seem to have messed up here.
>>
>> Why does the testing framework think that I was targeting master? Was
>> my subject prefix wrong?
>
> Why is there "meta-oe" in there? This is oe-core, not meta-oe...

Indeed that was an error on my end, using the wrong subject prefix.

-- 
Med Vänliga Hälsningar / Best Regards

Mirza Krak
Senior Embedded Engineer

Endian Technologies AB
Flöjelbergsgatan 11
SE-431 37 Mölndal, Sweden
mobile: +46 730 28 06 22
email: mirza.krak@endian.se
www.endian.se

Re: ✗ patchtest: failure for [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

[Paul Eggleton]

Hi Mirza,

On Monday, 15 May 2017 7:05:23 PM NZST Mirza Krak wrote:
> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
> > == Series Details ==
> >
> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
> > Revision: 1
> > URL   : https://patchwork.openembedded.org/series/6671/
> > State : failure
> 
> I seem to have messed up here.
> 
> Why does the testing framework think that I was targeting master? Was
> my subject prefix wrong?

It probably doesn't understand "," as a separator and thus didn't see "morty" 
as a branch name and assumed master as the default - if that's the case we 
should probably fix that.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: ✗ patchtest: failure for [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

[Mirza Krak]

Hi Paul.

2017-05-16 5:42 GMT+02:00 Paul Eggleton <paul.eggleton@linux.intel.com>:
> Hi Mirza,
>
> On Monday, 15 May 2017 7:05:23 PM NZST Mirza Krak wrote:
>> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
>> > == Series Details ==
>> >
>> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
>> > Revision: 1
>> > URL   : https://patchwork.openembedded.org/series/6671/
>> > State : failure
>>
>> I seem to have messed up here.
>>
>> Why does the testing framework think that I was targeting master? Was
>> my subject prefix wrong?
>
> It probably doesn't understand "," as a separator and thus didn't see "morty"
> as a branch name and assumed master as the default - if that's the case we
> should probably fix that.

I actually did not use "," as seperatator. Do not know where this came
from. My patch is [1].

I guess my error here was adding "meta-oe" as subject prefix in
oe-core mailing list, and I probably triggered some weird behavior in
patchwork with this?

[1]. http://lists.openembedded.org/pipermail/openembedded-core/2017-May/136489.html


-- 
Med Vänliga Hälsningar / Best Regards

Mirza Krak
Senior Embedded Engineer

Endian Technologies AB
Flöjelbergsgatan 11
SE-431 37 Mölndal, Sweden
mobile: +46 730 28 06 22
email: mirza.krak@endian.se
www.endian.se