From: Greg KH <greg@kroah.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Scott Branden <sbranden@broadcom.com>,
linux-iio@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Pavel Roskin <plroskin@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
Date: Tue, 16 May 2017 08:41:16 +0200 [thread overview]
Message-ID: <20170516064116.GA30503@kroah.com> (raw)
In-Reply-To: <20170516060826.wnw3mpq5makpnptt@sapphire.tkos.co.il>
On Tue, May 16, 2017 at 09:08:27AM +0300, Baruch Siach wrote:
> Hi Greg,
>
> On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > > The third argument of devm_request_threaded_irq() is the primary
> > > handler. It is called in hardirq context and checks whether the
> > > interrupt is relevant to the device. If the primary handler returns
> > > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > > scheduled to run in process context.
> > >
> > > bcm_iproc_adc.c uses the secondary handler as the primary one
> > > and the other way around. So this patch fixes the same, along with
> > > re-naming the secondary handler and primary handler names properly.
> > >
> > > Tested on the BCM9583XX iProc SoC based boards.
> > >
> > > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > > ---
> > > drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
>
> File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
>
> Maybe linking to
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would
> be better.
Ah, good point, I've updated my formletter now, thanks for this.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
Date: Tue, 16 May 2017 08:41:16 +0200 [thread overview]
Message-ID: <20170516064116.GA30503@kroah.com> (raw)
In-Reply-To: <20170516060826.wnw3mpq5makpnptt@sapphire.tkos.co.il>
On Tue, May 16, 2017 at 09:08:27AM +0300, Baruch Siach wrote:
> Hi Greg,
>
> On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > > The third argument of devm_request_threaded_irq() is the primary
> > > handler. It is called in hardirq context and checks whether the
> > > interrupt is relevant to the device. If the primary handler returns
> > > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > > scheduled to run in process context.
> > >
> > > bcm_iproc_adc.c uses the secondary handler as the primary one
> > > and the other way around. So this patch fixes the same, along with
> > > re-naming the secondary handler and primary handler names properly.
> > >
> > > Tested on the BCM9583XX iProc SoC based boards.
> > >
> > > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > > ---
> > > drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
>
> File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
>
> Maybe linking to
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would
> be better.
Ah, good point, I've updated my formletter now, thanks for this.
greg k-h
next prev parent reply other threads:[~2017-05-16 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 5:49 [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's Raveendra Padasalagi
2017-05-16 5:49 ` Raveendra Padasalagi
2017-05-16 6:01 ` Greg KH
2017-05-16 6:01 ` Greg KH
2017-05-16 6:08 ` Baruch Siach
2017-05-16 6:08 ` Baruch Siach
2017-05-16 6:41 ` Greg KH [this message]
2017-05-16 6:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516064116.GA30503@kroah.com \
--to=greg@kroah.com \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plroskin@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=raveendra.padasalagi@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.