All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Stefano Babic <sbabic@denx.de>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Fix broken package fbida
Date: Tue, 16 May 2017 09:56:39 +0200	[thread overview]
Message-ID: <20170516075639.GC3088@jama> (raw)
In-Reply-To: <1494605830-18765-1-git-send-email-sbabic@denx.de>

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

On Fri, May 12, 2017 at 06:17:10PM +0200, Stefano Babic wrote:
> Missing pkgconfig does not let build the package.

The summary should start with
fbida:
I've updated the summary when adding it to master-next

How does this relate to:
https://patchwork.openembedded.org/patch/138960/
?

Was Marek's change just a fix for the case when the pkgconfig wasn't
used because of missing inherit?

> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> 
> Tested on current master, i.MX6 ARM target
> 
>  meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> index eb31f7b..1febac8 100644
> --- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> +++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> @@ -18,6 +18,8 @@ SRC_URI[sha256sum] = "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d
>  
>  B = "${WORKDIR}/build"
>  
> +inherit pkgconfig
> +
>  EXTRA_OEMAKE = "STRIP= 'srcdir=${S}' -f ${S}/GNUmakefile"
>  
>  PACKAGECONFIG ??= "gif png curl"
> @@ -66,5 +68,3 @@ do_install() {
>  }
>  
>  RDEPENDS_${PN} = "ttf-dejavu-sans-mono bash"
> -
> -PNBLACKLIST[fbida] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130677/ - the recipe will be removed on 2017-09-01 unless the issue is fixed"
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  reply	other threads:[~2017-05-16  7:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 16:17 [PATCH] Fix broken package fbida Stefano Babic
2017-05-16  7:56 ` Martin Jansa [this message]
2017-05-16  8:30   ` Stefano Babic
2017-05-16  9:15     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516075639.GC3088@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=sbabic@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.