* [PATCH] Fix broken package fbida
@ 2017-05-12 16:17 Stefano Babic
2017-05-16 7:56 ` Martin Jansa
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Babic @ 2017-05-12 16:17 UTC (permalink / raw)
To: openembedded-devel
Missing pkgconfig does not let build the package.
Signed-off-by: Stefano Babic <sbabic@denx.de>
---
Tested on current master, i.MX6 ARM target
meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
index eb31f7b..1febac8 100644
--- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
+++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
@@ -18,6 +18,8 @@ SRC_URI[sha256sum] = "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d
B = "${WORKDIR}/build"
+inherit pkgconfig
+
EXTRA_OEMAKE = "STRIP= 'srcdir=${S}' -f ${S}/GNUmakefile"
PACKAGECONFIG ??= "gif png curl"
@@ -66,5 +68,3 @@ do_install() {
}
RDEPENDS_${PN} = "ttf-dejavu-sans-mono bash"
-
-PNBLACKLIST[fbida] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130677/ - the recipe will be removed on 2017-09-01 unless the issue is fixed"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix broken package fbida
2017-05-12 16:17 [PATCH] Fix broken package fbida Stefano Babic
@ 2017-05-16 7:56 ` Martin Jansa
2017-05-16 8:30 ` Stefano Babic
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2017-05-16 7:56 UTC (permalink / raw)
To: Stefano Babic; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]
On Fri, May 12, 2017 at 06:17:10PM +0200, Stefano Babic wrote:
> Missing pkgconfig does not let build the package.
The summary should start with
fbida:
I've updated the summary when adding it to master-next
How does this relate to:
https://patchwork.openembedded.org/patch/138960/
?
Was Marek's change just a fix for the case when the pkgconfig wasn't
used because of missing inherit?
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>
> Tested on current master, i.MX6 ARM target
>
> meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> index eb31f7b..1febac8 100644
> --- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> +++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> @@ -18,6 +18,8 @@ SRC_URI[sha256sum] = "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d
>
> B = "${WORKDIR}/build"
>
> +inherit pkgconfig
> +
> EXTRA_OEMAKE = "STRIP= 'srcdir=${S}' -f ${S}/GNUmakefile"
>
> PACKAGECONFIG ??= "gif png curl"
> @@ -66,5 +68,3 @@ do_install() {
> }
>
> RDEPENDS_${PN} = "ttf-dejavu-sans-mono bash"
> -
> -PNBLACKLIST[fbida] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130677/ - the recipe will be removed on 2017-09-01 unless the issue is fixed"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix broken package fbida
2017-05-16 7:56 ` Martin Jansa
@ 2017-05-16 8:30 ` Stefano Babic
2017-05-16 9:15 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Babic @ 2017-05-16 8:30 UTC (permalink / raw)
To: Martin Jansa, Stefano Babic; +Cc: Marek Vasut, openembedded-devel
Hi Martin,
On 16/05/2017 09:56, Martin Jansa wrote:
> On Fri, May 12, 2017 at 06:17:10PM +0200, Stefano Babic wrote:
>> Missing pkgconfig does not let build the package.
>
> The summary should start with
> fbida:
Sorry, noted for next time.
> I've updated the summary when adding it to master-next
>
> How does this relate to:
> https://patchwork.openembedded.org/patch/138960/
> ?
>
> Was Marek's change just a fix for the case when the pkgconfig wasn't
> used because of missing inherit?
>
IMHO the changes are unrelated - I have also changed as Marek did and
after that I noted he has already sent a patch. Absolute path /usr/local
is hard-coded in Makefile, and this is what Marek fixed. Marek, is it
correct ?
Regards,
Stefano
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>>
>> Tested on current master, i.MX6 ARM target
>>
>> meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> index eb31f7b..1febac8 100644
>> --- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> +++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> @@ -18,6 +18,8 @@ SRC_URI[sha256sum] = "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d
>>
>> B = "${WORKDIR}/build"
>>
>> +inherit pkgconfig
>> +
>> EXTRA_OEMAKE = "STRIP= 'srcdir=${S}' -f ${S}/GNUmakefile"
>>
>> PACKAGECONFIG ??= "gif png curl"
>> @@ -66,5 +68,3 @@ do_install() {
>> }
>>
>> RDEPENDS_${PN} = "ttf-dejavu-sans-mono bash"
>> -
>> -PNBLACKLIST[fbida] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130677/ - the recipe will be removed on 2017-09-01 unless the issue is fixed"
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix broken package fbida
2017-05-16 8:30 ` Stefano Babic
@ 2017-05-16 9:15 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2017-05-16 9:15 UTC (permalink / raw)
To: Stefano Babic, Martin Jansa; +Cc: openembedded-devel
On 05/16/2017 10:30 AM, Stefano Babic wrote:
> Hi Martin,
Hi,
> On 16/05/2017 09:56, Martin Jansa wrote:
>> On Fri, May 12, 2017 at 06:17:10PM +0200, Stefano Babic wrote:
>>> Missing pkgconfig does not let build the package.
>>
>> The summary should start with
>> fbida:
>
> Sorry, noted for next time.
>
>> I've updated the summary when adding it to master-next
>>
>> How does this relate to:
>> https://patchwork.openembedded.org/patch/138960/
>> ?
>>
>> Was Marek's change just a fix for the case when the pkgconfig wasn't
>> used because of missing inherit?
>>
>
> IMHO the changes are unrelated - I have also changed as Marek did and
> after that I noted he has already sent a patch. Absolute path /usr/local
> is hard-coded in Makefile, and this is what Marek fixed. Marek, is it
> correct ?
Yeah. The inherit pkgconfig is needed too (since some time), I have a
patch in a tree but forgot to submit it. Clearly you were faster.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-16 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-12 16:17 [PATCH] Fix broken package fbida Stefano Babic
2017-05-16 7:56 ` Martin Jansa
2017-05-16 8:30 ` Stefano Babic
2017-05-16 9:15 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.