* [PATCH] Staging: comedi: comedidev.h: fixed a warning
@ 2017-05-16 8:30 srishti
2017-05-16 8:40 ` Dan Carpenter
2017-05-16 9:15 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: srishti @ 2017-05-16 8:30 UTC (permalink / raw)
To: abbotti; +Cc: hsweeten, gregkh, thrust73, devel, linux-kernel, srishti
Fixed a warning : struct comedi_lrange is generally constant.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
drivers/staging/comedi/comedidev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 1bb9986..82df090 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;
* There may also be a flag that indicates the minimum and maximum are merely
* scale factors for an unknown, external reference.
*/
-struct comedi_lrange {
+const struct comedi_lrange {
int length;
struct comedi_krange range[];
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning
2017-05-16 8:30 [PATCH] Staging: comedi: comedidev.h: fixed a warning srishti
@ 2017-05-16 8:40 ` Dan Carpenter
2017-05-16 9:15 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-05-16 8:40 UTC (permalink / raw)
To: srishti; +Cc: abbotti, devel, thrust73, gregkh, linux-kernel
Compile test your patches.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning
2017-05-16 8:30 [PATCH] Staging: comedi: comedidev.h: fixed a warning srishti
2017-05-16 8:40 ` Dan Carpenter
@ 2017-05-16 9:15 ` Greg KH
2017-05-16 15:57 ` srishti sharma
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2017-05-16 9:15 UTC (permalink / raw)
To: srishti; +Cc: abbotti, devel, thrust73, linux-kernel
On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
> Fixed a warning : struct comedi_lrange is generally constant.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
As Dan pointed out, you _HAVE_ to test-build your changes.
Also, your "From:" line didn't match your signed-off-by line, so I
couldn't accept this anyway.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning
2017-05-16 9:15 ` Greg KH
@ 2017-05-16 15:57 ` srishti sharma
0 siblings, 0 replies; 4+ messages in thread
From: srishti sharma @ 2017-05-16 15:57 UTC (permalink / raw)
To: Greg KH, Ian Abbott, devel, linux-kernel, Abc Abc
On Tue, May 16, 2017 at 2:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
>> Fixed a warning : struct comedi_lrange is generally constant.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>
> As Dan pointed out, you _HAVE_ to test-build your changes.
>
> Also, your "From:" line didn't match your signed-off-by line, so I
> couldn't accept this anyway.
>
> thanks,
>
> greg k-h
Thanks for pointing out the error , but this patch is not needed as it
was for fixing a warning produced by checkpatch.pl that says struct
comedi_lrange is usually constant . But on building the code I get
another warning which says that the type qualifier is useless.
Regards,
Srishti
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-16 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-16 8:30 [PATCH] Staging: comedi: comedidev.h: fixed a warning srishti
2017-05-16 8:40 ` Dan Carpenter
2017-05-16 9:15 ` Greg KH
2017-05-16 15:57 ` srishti sharma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.