From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kvm: nVMX: off by one in vmx_write_pml_buffer()
Date: Tue, 16 May 2017 13:56:18 +0000 [thread overview]
Message-ID: <20170516135617.GB13731@potion> (raw)
In-Reply-To: <20170510194317.uh72h3ez7hnvn62v@mwanda>
2017-05-10 22:43+0300, Dan Carpenter:
> There are PML_ENTITY_NUM elements in the pml_address[] array so the >
> should be >= or we write beyond the end of the array when we do:
>
> pml_address[vmcs12->guest_pml_index--] = gpa;
>
> Fixes: c5f983f6e845 ("nVMX: Implement emulated Page Modification Logging")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to kvm/master, thanks.
(v1 was deemed better after all.)
WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kvm: nVMX: off by one in vmx_write_pml_buffer()
Date: Tue, 16 May 2017 15:56:18 +0200 [thread overview]
Message-ID: <20170516135617.GB13731@potion> (raw)
In-Reply-To: <20170510194317.uh72h3ez7hnvn62v@mwanda>
2017-05-10 22:43+0300, Dan Carpenter:
> There are PML_ENTITY_NUM elements in the pml_address[] array so the >
> should be >= or we write beyond the end of the array when we do:
>
> pml_address[vmcs12->guest_pml_index--] = gpa;
>
> Fixes: c5f983f6e845 ("nVMX: Implement emulated Page Modification Logging")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to kvm/master, thanks.
(v1 was deemed better after all.)
next prev parent reply other threads:[~2017-05-16 13:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 19:43 [PATCH] kvm: nVMX: off by one in vmx_write_pml_buffer() Dan Carpenter
2017-05-10 19:43 ` Dan Carpenter
2017-05-10 20:18 ` Bandan Das
2017-05-10 20:18 ` Bandan Das
2017-05-10 20:43 ` [PATCH v2] " Dan Carpenter
2017-05-10 20:43 ` Dan Carpenter
2017-05-11 7:31 ` Paolo Bonzini
2017-05-11 7:31 ` Paolo Bonzini
2017-05-11 7:42 ` Dan Carpenter
2017-05-11 7:42 ` Dan Carpenter
2017-05-11 7:52 ` Paolo Bonzini
2017-05-11 7:52 ` Paolo Bonzini
2017-05-11 13:56 ` Bandan Das
2017-05-11 13:56 ` Bandan Das
2017-05-11 15:23 ` Paolo Bonzini
2017-05-11 15:23 ` Paolo Bonzini
2017-05-11 17:06 ` Bandan Das
2017-05-11 17:06 ` Bandan Das
2017-05-16 13:56 ` Radim Krčmář [this message]
2017-05-16 13:56 ` [PATCH] " Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516135617.GB13731@potion \
--to=rkrcmar@redhat.com \
--cc=bsd@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.