All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt: gta04: fix polarity of clocks for mcbsp4
@ 2017-04-28 10:27 ` Andreas Kemnade
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2017-04-28 10:27 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, mark.rutland, linux, linux-omap,
	devicetree, linux-arm-kernel, H. Nikolaus Schaller,
	Discussions about the Letux Kernel
  Cc: Andreas Kemnade

The clock polarity setting of the mcbsp connected to
the modem was wrong so almost only noise
was received.
With this patch it is also the same as it was on
earlier non-dt kernels where it was working properly

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 16b237d3..c0d9d4b 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -68,7 +68,8 @@
 		simple-audio-card,bitclock-master = <&telephony_link_master>;
 		simple-audio-card,frame-master = <&telephony_link_master>;
 		simple-audio-card,format = "i2s";
-
+		simple-audio-card,bitclock-inversion;
+		simple-audio-card,frame-inversion;
 		simple-audio-card,cpu {
 			sound-dai = <&mcbsp4>;
 		};
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] dt: gta04: fix polarity of clocks for mcbsp4
@ 2017-04-28 10:27 ` Andreas Kemnade
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2017-04-28 10:27 UTC (permalink / raw)
  To: linux-arm-kernel

The clock polarity setting of the mcbsp connected to
the modem was wrong so almost only noise
was received.
With this patch it is also the same as it was on
earlier non-dt kernels where it was working properly

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 16b237d3..c0d9d4b 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -68,7 +68,8 @@
 		simple-audio-card,bitclock-master = <&telephony_link_master>;
 		simple-audio-card,frame-master = <&telephony_link_master>;
 		simple-audio-card,format = "i2s";
-
+		simple-audio-card,bitclock-inversion;
+		simple-audio-card,frame-inversion;
 		simple-audio-card,cpu {
 			sound-dai = <&mcbsp4>;
 		};
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] dt: gta04: fix polarity of clocks for mcbsp4
  2017-04-28 10:27 ` Andreas Kemnade
@ 2017-05-16 15:09     ` Tony Lindgren
  -1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2017-05-16 15:09 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: bcousson-rdvid1DuHRBWk0Htik3J/w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	H. Nikolaus Schaller, Discussions about the Letux Kernel

* Andreas Kemnade <andreas-cLv4Z9ELZ06ZuzBka8ofvg@public.gmane.org> [170428 03:30]:
> The clock polarity setting of the mcbsp connected to
> the modem was wrong so almost only noise
> was received.
> With this patch it is also the same as it was on
> earlier non-dt kernels where it was working properly

Applying into omap-for-v4.12/fixes.

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] dt: gta04: fix polarity of clocks for mcbsp4
@ 2017-05-16 15:09     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2017-05-16 15:09 UTC (permalink / raw)
  To: linux-arm-kernel

* Andreas Kemnade <andreas@kemnade.info> [170428 03:30]:
> The clock polarity setting of the mcbsp connected to
> the modem was wrong so almost only noise
> was received.
> With this patch it is also the same as it was on
> earlier non-dt kernels where it was working properly

Applying into omap-for-v4.12/fixes.

Thanks,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-16 15:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 10:27 [PATCH] dt: gta04: fix polarity of clocks for mcbsp4 Andreas Kemnade
2017-04-28 10:27 ` Andreas Kemnade
     [not found] ` <1493375255-21094-1-git-send-email-andreas-cLv4Z9ELZ06ZuzBka8ofvg@public.gmane.org>
2017-05-16 15:09   ` Tony Lindgren
2017-05-16 15:09     ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.