All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonsoo Kim <js1304@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	mgorman@techsingularity.net, Laura Abbott <lauraa@codeaurora.org>,
	Minchan Kim <minchan@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Russell King <linux@armlinux.org.uk>,
	Will Deacon <will.deacon@arm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@lge.com
Subject: Re: [PATCH v7 0/7] Introduce ZONE_CMA
Date: Wed, 17 May 2017 16:44:26 +0900	[thread overview]
Message-ID: <20170517074424.GC18406@js1304-desktop> (raw)
In-Reply-To: <20170516084734.GC2481@dhcp22.suse.cz>

> > 
> > Okay. We did a lot of discussion so it's better to summarise it.
> > 
> > 1. ZONE_CMA might be a nicer solution than MIGRATETYPE.
> > 2. Additional bit in page flags would cause another kind of
> > maintenance problem so it's better to avoid it as much as possible.
> > 3. Abusing ZONE_MOVABLE looks better than introducing ZONE_CMA since
> > it doesn't need additional bit in page flag.
> > 4. (Not-yet-finished) If ZONE_CMA doesn't need extra bit in page
> > flags with hacky magic and it has no performance regression,
> > ??? (it's okay to use separate zone for CMA?)
> 
> As mentioned above. I do not see why we should go over additional hops
> just to have a zone which is not strictly needed. So if there are no
> inherent problems reusing MOVABLE/HIGMEM zone then a separate zone
> sounds like a wrong direction.
> 
> But let me repeat. I am _not_ convinced that the migratetype situation
> is all that bad and unfixable. You have mentioned some issues with the
> current approach but none of them seem inherently unfixable. So I would
> still prefer keeping the current way. But I am not going to insist if
> you _really_ believe that the long term maintenance cost will be higher
> than a zone approach and you can reuse MOVABLE/HIGHMEM zones without
> disruptive changes. I can help you with the hotplug part of the MOVABLE
> zone because that is desirable on its own.

Okay. Thanks for sharing your opinion. I will decide the final
direction after some investigation.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <js1304@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	mgorman@techsingularity.net, Laura Abbott <lauraa@codeaurora.org>,
	Minchan Kim <minchan@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Russell King <linux@armlinux.org.uk>,
	Will Deacon <will.deacon@arm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@lge.com
Subject: Re: [PATCH v7 0/7] Introduce ZONE_CMA
Date: Wed, 17 May 2017 16:44:26 +0900	[thread overview]
Message-ID: <20170517074424.GC18406@js1304-desktop> (raw)
In-Reply-To: <20170516084734.GC2481@dhcp22.suse.cz>

> > 
> > Okay. We did a lot of discussion so it's better to summarise it.
> > 
> > 1. ZONE_CMA might be a nicer solution than MIGRATETYPE.
> > 2. Additional bit in page flags would cause another kind of
> > maintenance problem so it's better to avoid it as much as possible.
> > 3. Abusing ZONE_MOVABLE looks better than introducing ZONE_CMA since
> > it doesn't need additional bit in page flag.
> > 4. (Not-yet-finished) If ZONE_CMA doesn't need extra bit in page
> > flags with hacky magic and it has no performance regression,
> > ??? (it's okay to use separate zone for CMA?)
> 
> As mentioned above. I do not see why we should go over additional hops
> just to have a zone which is not strictly needed. So if there are no
> inherent problems reusing MOVABLE/HIGMEM zone then a separate zone
> sounds like a wrong direction.
> 
> But let me repeat. I am _not_ convinced that the migratetype situation
> is all that bad and unfixable. You have mentioned some issues with the
> current approach but none of them seem inherently unfixable. So I would
> still prefer keeping the current way. But I am not going to insist if
> you _really_ believe that the long term maintenance cost will be higher
> than a zone approach and you can reuse MOVABLE/HIGHMEM zones without
> disruptive changes. I can help you with the hotplug part of the MOVABLE
> zone because that is desirable on its own.

Okay. Thanks for sharing your opinion. I will decide the final
direction after some investigation.

Thanks.

  reply	other threads:[~2017-05-17  7:44 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  3:17 [PATCH v7 0/7] Introduce ZONE_CMA js1304
2017-04-11  3:17 ` js1304
2017-04-11  3:17 ` [PATCH v7 1/7] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request js1304
2017-04-11  3:17   ` js1304
2017-04-17  7:38   ` Minchan Kim
2017-04-17  7:38     ` Minchan Kim
2017-04-21  1:32     ` Joonsoo Kim
2017-04-21  1:32       ` Joonsoo Kim
2017-04-11  3:17 ` [PATCH v7 2/7] mm/cma: introduce new zone, ZONE_CMA js1304
2017-04-11  3:17   ` js1304
2017-04-11  3:17 ` [PATCH v7 3/7] mm/cma: populate ZONE_CMA js1304
2017-04-11  3:17   ` js1304
2017-04-11  3:17 ` [PATCH v7 4/7] mm/cma: remove ALLOC_CMA js1304
2017-04-11  3:17   ` js1304
2017-04-11  3:17 ` [PATCH v7 5/7] mm/cma: remove MIGRATE_CMA js1304
2017-04-11  3:17   ` js1304
2017-04-11  3:17 ` [PATCH v7 6/7] mm/cma: remove per zone CMA stat js1304
2017-04-11  3:17   ` js1304
2017-04-11  3:17 ` [PATCH v7 7/7] ARM: CMA: avoid re-mapping CMA region if CONFIG_HIGHMEM js1304
2017-04-11  3:17   ` js1304
2017-04-11 18:15 ` [PATCH v7 0/7] Introduce ZONE_CMA Michal Hocko
2017-04-11 18:15   ` Michal Hocko
2017-04-12  1:35   ` Joonsoo Kim
2017-04-12  1:35     ` Joonsoo Kim
2017-04-13 11:56     ` Michal Hocko
2017-04-13 11:56       ` Michal Hocko
2017-04-17  2:02       ` Joonsoo Kim
2017-04-17  2:02         ` Joonsoo Kim
2017-04-21  1:35         ` Joonsoo Kim
2017-04-21  1:35           ` Joonsoo Kim
2017-04-21  6:54           ` Michal Hocko
2017-04-21  6:54             ` Michal Hocko
2017-04-24 13:09         ` Michal Hocko
2017-04-24 13:09           ` Michal Hocko
2017-04-25  3:42           ` Joonsoo Kim
2017-04-25  3:42             ` Joonsoo Kim
2017-04-27 15:06             ` Michal Hocko
2017-04-27 15:06               ` Michal Hocko
2017-04-28  8:04               ` Generic approach to customizable zones - was: " Igor Stoppa
2017-04-28  8:04                 ` Igor Stoppa
2017-04-28  8:36                 ` Michal Hocko
2017-04-28  8:36                   ` Michal Hocko
2017-04-28  9:04                   ` Igor Stoppa
2017-04-28  9:04                     ` Igor Stoppa
2017-05-02  4:01               ` Joonsoo Kim
2017-05-02  4:01                 ` Joonsoo Kim
2017-05-02 13:32                 ` Michal Hocko
2017-05-02 13:32                   ` Michal Hocko
2017-05-11  2:12                   ` Joonsoo Kim
2017-05-11  2:12                     ` Joonsoo Kim
2017-05-11  9:13                     ` Michal Hocko
2017-05-11  9:13                       ` Michal Hocko
2017-05-12  2:00                       ` Joonsoo Kim
2017-05-12  2:00                         ` Joonsoo Kim
2017-05-12  6:38                         ` Michal Hocko
2017-05-12  6:38                           ` Michal Hocko
2017-05-15  3:57                           ` Joonsoo Kim
2017-05-15  3:57                             ` Joonsoo Kim
2017-05-16  8:47                             ` Michal Hocko
2017-05-16  8:47                               ` Michal Hocko
2017-05-17  7:44                               ` Joonsoo Kim [this message]
2017-05-17  7:44                                 ` Joonsoo Kim
2017-05-02  8:06               ` Vlastimil Babka
2017-05-02  8:06                 ` Vlastimil Babka
2017-05-02 13:03                 ` Michal Hocko
2017-05-02 13:03                   ` Michal Hocko
2017-05-02 13:41                   ` Igor Stoppa
2017-05-02 13:41                     ` Igor Stoppa
2017-05-04 12:33                   ` Vlastimil Babka
2017-05-04 12:33                     ` Vlastimil Babka
2017-05-04 12:46                     ` Michal Hocko
2017-05-04 12:46                       ` Michal Hocko
2017-05-11  8:51                       ` Vlastimil Babka
2017-05-11  8:51                         ` Vlastimil Babka
2017-04-12  1:39 ` Joonsoo Kim
2017-04-12  1:39   ` Joonsoo Kim
2017-04-24  4:08 ` Bob Liu
2017-04-24  4:08   ` Bob Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170517074424.GC18406@js1304-desktop \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@lge.com \
    --cc=lauraa@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.