* [PATCH] iommu/mediatek: include linux/dma-mapping.h
@ 2017-05-11 11:35 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-05-11 11:35 UTC (permalink / raw)
To: Joerg Roedel, Matthias Brugger
Cc: Arnd Bergmann, linux-kernel, iommu, linux-mediatek, Honghui Zhang,
linux-arm-kernel
The mediatek iommu driver relied on an implicit include of dma-mapping.h,
but for some reason that is no longer there in 4.12-rc1:
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
This adds an explicit #include to make it build again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iommu/mtk_iommu_v1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
index a27ef570c328..bc1efbfb9ddf 100644
--- a/drivers/iommu/mtk_iommu_v1.c
+++ b/drivers/iommu/mtk_iommu_v1.c
@@ -18,6 +18,7 @@
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/device.h>
+#include <linux/dma-mapping.h>
#include <linux/dma-iommu.h>
#include <linux/err.h>
#include <linux/interrupt.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] iommu/mediatek: include linux/dma-mapping.h
@ 2017-05-11 11:35 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-05-11 11:35 UTC (permalink / raw)
To: linux-arm-kernel
The mediatek iommu driver relied on an implicit include of dma-mapping.h,
but for some reason that is no longer there in 4.12-rc1:
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
This adds an explicit #include to make it build again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iommu/mtk_iommu_v1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
index a27ef570c328..bc1efbfb9ddf 100644
--- a/drivers/iommu/mtk_iommu_v1.c
+++ b/drivers/iommu/mtk_iommu_v1.c
@@ -18,6 +18,7 @@
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/device.h>
+#include <linux/dma-mapping.h>
#include <linux/dma-iommu.h>
#include <linux/err.h>
#include <linux/interrupt.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] iommu/mediatek: include linux/dma-mapping.h
@ 2017-05-11 11:35 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-05-11 11:35 UTC (permalink / raw)
To: Joerg Roedel, Matthias Brugger
Cc: Arnd Bergmann, Honghui Zhang, iommu, linux-arm-kernel,
linux-mediatek, linux-kernel
The mediatek iommu driver relied on an implicit include of dma-mapping.h,
but for some reason that is no longer there in 4.12-rc1:
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
This adds an explicit #include to make it build again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iommu/mtk_iommu_v1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
index a27ef570c328..bc1efbfb9ddf 100644
--- a/drivers/iommu/mtk_iommu_v1.c
+++ b/drivers/iommu/mtk_iommu_v1.c
@@ -18,6 +18,7 @@
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/device.h>
+#include <linux/dma-mapping.h>
#include <linux/dma-iommu.h>
#include <linux/err.h>
#include <linux/interrupt.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h
2017-05-11 11:35 ` Arnd Bergmann
(?)
@ 2017-05-17 12:51 ` Joerg Roedel
-1 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2017-05-17 12:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Matthias Brugger,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote:
> The mediatek iommu driver relied on an implicit include of dma-mapping.h,
> but for some reason that is no longer there in 4.12-rc1:
>
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
> drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
> drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
>
> This adds an explicit #include to make it build again.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Applied to iommu/fixes, thanks Arnd.
This was probably another victim of
208480b iommu: Remove trace-events include from iommu.h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iommu/mediatek: include linux/dma-mapping.h
@ 2017-05-17 12:51 ` Joerg Roedel
0 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2017-05-17 12:51 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote:
> The mediatek iommu driver relied on an implicit include of dma-mapping.h,
> but for some reason that is no longer there in 4.12-rc1:
>
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
> drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
> drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
>
> This adds an explicit #include to make it build again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to iommu/fixes, thanks Arnd.
This was probably another victim of
208480b iommu: Remove trace-events include from iommu.h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h
@ 2017-05-17 12:51 ` Joerg Roedel
0 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2017-05-17 12:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Matthias Brugger, Honghui Zhang, iommu, linux-arm-kernel,
linux-mediatek, linux-kernel
On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote:
> The mediatek iommu driver relied on an implicit include of dma-mapping.h,
> but for some reason that is no longer there in 4.12-rc1:
>
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
> drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
> drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
>
> This adds an explicit #include to make it build again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to iommu/fixes, thanks Arnd.
This was probably another victim of
208480b iommu: Remove trace-events include from iommu.h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-17 12:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 11:35 [PATCH] iommu/mediatek: include linux/dma-mapping.h Arnd Bergmann
2017-05-11 11:35 ` Arnd Bergmann
2017-05-11 11:35 ` Arnd Bergmann
[not found] ` <20170511113619.2596882-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-05-17 12:51 ` Joerg Roedel
2017-05-17 12:51 ` Joerg Roedel
2017-05-17 12:51 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.