From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] trivial: Remove unneeded ifndef in memory.h
Date: Thu, 18 May 2017 12:49:47 +0100 [thread overview]
Message-ID: <20170518114946.GB2467@work-vm> (raw)
In-Reply-To: <20170518103642.27796-1-quintela@redhat.com>
* Juan Quintela (quintela@redhat.com) wrote:
> All the file is surounded already by #ifndef CONFIG_USER_ONLY.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Ah yes, the patch that added the inner ifndef added it to
every use of exec/hwaddr.h.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> include/exec/memory.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 99e0f54..6b5b953 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -17,9 +17,7 @@
> #ifndef CONFIG_USER_ONLY
>
> #include "exec/cpu-common.h"
> -#ifndef CONFIG_USER_ONLY
> #include "exec/hwaddr.h"
> -#endif
> #include "exec/memattrs.h"
> #include "exec/ramlist.h"
> #include "qemu/queue.h"
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
Date: Thu, 18 May 2017 12:49:47 +0100 [thread overview]
Message-ID: <20170518114946.GB2467@work-vm> (raw)
In-Reply-To: <20170518103642.27796-1-quintela@redhat.com>
* Juan Quintela (quintela@redhat.com) wrote:
> All the file is surounded already by #ifndef CONFIG_USER_ONLY.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Ah yes, the patch that added the inner ifndef added it to
every use of exec/hwaddr.h.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> include/exec/memory.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 99e0f54..6b5b953 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -17,9 +17,7 @@
> #ifndef CONFIG_USER_ONLY
>
> #include "exec/cpu-common.h"
> -#ifndef CONFIG_USER_ONLY
> #include "exec/hwaddr.h"
> -#endif
> #include "exec/memattrs.h"
> #include "exec/ramlist.h"
> #include "qemu/queue.h"
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-05-18 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:36 [Qemu-trivial] [PATCH] trivial: Remove unneeded ifndef in memory.h Juan Quintela
2017-05-18 10:36 ` [Qemu-devel] " Juan Quintela
2017-05-18 11:49 ` Dr. David Alan Gilbert [this message]
2017-05-18 11:49 ` Dr. David Alan Gilbert
2017-05-18 14:57 ` [Qemu-trivial] " Laurent Vivier
2017-05-18 14:57 ` [Qemu-devel] " Laurent Vivier
2017-05-23 14:45 ` [Qemu-trivial] " Michael Tokarev
2017-05-23 14:45 ` [Qemu-devel] " Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2017-05-18 10:30 [Qemu-trivial] " Juan Quintela
2017-05-18 10:37 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518114946.GB2467@work-vm \
--to=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.