[PATCH nvme-cli] fabrics: add option to override drivers queue depth also for connect-all command

[PATCH nvme-cli] fabrics: add option to override drivers queue depth also for connect-all command

[Johannes Thumshirn]

Currently it is not possible to override the fabrics drivers default
queue depth with the nvme userspace utility's 'connect-all' command,
but only when using the 'connect' command.

Add an option to override the drivers default queue depth for NVMe
over fabrics with the 'connect-all' command as we did previouslt with the
'connect' command.

Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>
---
 Documentation/nvme-connect-all.txt | 5 +++++
 fabrics.c                          | 1 +
 2 files changed, 6 insertions(+)

diff --git a/Documentation/nvme-connect-all.txt b/Documentation/nvme-connect-all.txt
index b4b3e40..03adac5 100644
--- a/Documentation/nvme-connect-all.txt
+++ b/Documentation/nvme-connect-all.txt
@@ -81,6 +81,11 @@ OPTIONS
 	and dump it to a raw binary file. By default 'nvme connect-all' will
 	dump the output to stdout.
 
+-Q <#>::
+--queue-size=<#>::
+	Overrides the default number of elements in the I/O queues created
+	by the driver.
+
 EXAMPLES
 --------
 * Connect to all records returned by the Discover Controller with IP4 address
diff --git a/fabrics.c b/fabrics.c
index a826ecc..bbcca47 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -782,6 +782,7 @@ int discover(const char *desc, int argc, char **argv, bool connect)
 		{"trsvcid",     's', "LIST", CFG_STRING, &cfg.trsvcid,     required_argument, "transport service id (e.g. IP port)" },
 		{"host-traddr", 'w', "LIST", CFG_STRING, &cfg.host_traddr, required_argument, "host traddr (e.g. FC WWN's)" },
 		{"hostnqn",     'q', "LIST", CFG_STRING, &cfg.hostnqn,     required_argument, "user-defined hostnqn (if default not used)" },
+		{"queue-size",  'Q', "LIST", CFG_STRING, &cfg.queue_size,  required_argument, "number of io queue elements to use (default 128)" },
 		{"raw",         'r', "LIST", CFG_STRING, &cfg.raw,         required_argument, "raw output file" },
 		{NULL},
 	};
-- 
2.12.0

[PATCH nvme-cli] fabrics: add option to override drivers queue depth also for connect-all command

[Johannes Thumshirn]

On 05/11/2017 07:48 PM, Johannes Thumshirn wrote:
> Currently it is not possible to override the fabrics drivers default
> queue depth with the nvme userspace utility's 'connect-all' command,
> but only when using the 'connect' command.
> 
> Add an option to override the drivers default queue depth for NVMe
> over fabrics with the 'connect-all' command as we did previouslt with the
> 'connect' command.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>
> ---

Keith, ping?


-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH nvme-cli] fabrics: add option to override drivers queue depth also for connect-all command

[Keith Busch]

On Thu, May 18, 2017@04:10:32PM +0200, Johannes Thumshirn wrote:
> On 05/11/2017 07:48 PM, Johannes Thumshirn wrote:
> > Currently it is not possible to override the fabrics drivers default
> > queue depth with the nvme userspace utility's 'connect-all' command,
> > but only when using the 'connect' command.
> > 
> > Add an option to override the drivers default queue depth for NVMe
> > over fabrics with the 'connect-all' command as we did previouslt with the
> > 'connect' command.
> > 
> > Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>
> > ---

Thanks, Johnanes, looks good, and applied to the repo.