[PATCH] tzcode-native: quote ${CC}

[PATCH] tzcode-native: quote ${CC}

[Enrico Scholz]

build fails else with

| + make -j 8 -l 6 cc=ccache gcc
| make: *** No rule to make target 'gcc'.  Stop.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
 meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
index 2084f79..165d2c6 100644
--- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
+++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
@@ -18,7 +18,7 @@ S = "${WORKDIR}"
 
 inherit native
 
-EXTRA_OEMAKE += "cc=${CC}"
+EXTRA_OEMAKE += "cc='${CC}'"
 
 do_install () {
         install -d ${D}${bindir}/
-- 
2.9.4

Re: [PATCH] tzcode-native: quote ${CC}

[Denys Dmytriyenko]

On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:
> build fails else with
> 
> | + make -j 8 -l 6 cc=ccache gcc
> | make: *** No rule to make target 'gcc'.  Stop.
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> ---
>  meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> index 2084f79..165d2c6 100644
> --- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> +++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> @@ -18,7 +18,7 @@ S = "${WORKDIR}"
>  
>  inherit native
>  
> -EXTRA_OEMAKE += "cc=${CC}"
> +EXTRA_OEMAKE += "cc='${CC}'"

Should these be double-quotes around ${CC}?


>  do_install () {
>          install -d ${D}${bindir}/
> -- 
> 2.9.4
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] tzcode-native: quote ${CC}

[Khem Raj]

On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:
>> build fails else with
>>
>> | + make -j 8 -l 6 cc=ccache gcc
>> | make: *** No rule to make target 'gcc'.  Stop.
>>
>> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
>> ---
>>  meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
>> index 2084f79..165d2c6 100644
>> --- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
>> +++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
>> @@ -18,7 +18,7 @@ S = "${WORKDIR}"
>>
>>  inherit native
>>
>> -EXTRA_OEMAKE += "cc=${CC}"
>> +EXTRA_OEMAKE += "cc='${CC}'"
>
> Should these be double-quotes around ${CC}?

I think this should work as such.

>
>
>>  do_install () {
>>          install -d ${D}${bindir}/
>> --
>> 2.9.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] tzcode-native: quote ${CC}

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

On Thu, May 18, 2017 at 11:57 AM, Khem Raj <raj.khem@gmail.com> wrote:

> On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko <denis@denix.org>
> wrote:
> > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:
> >> build fails else with
> >>
> >> | + make -j 8 -l 6 cc=ccache gcc
> >> | make: *** No rule to make target 'gcc'.  Stop.
> >>
> >> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> >> ---
> >>  meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> >> index 2084f79..165d2c6 100644
> >> --- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> >> +++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> >> @@ -18,7 +18,7 @@ S = "${WORKDIR}"
> >>
> >>  inherit native
> >>
> >> -EXTRA_OEMAKE += "cc=${CC}"
> >> +EXTRA_OEMAKE += "cc='${CC}'"
> >
> > Should these be double-quotes around ${CC}?
>
> I think this should work as such.


Indeed, it’s expanded by bitbake, not the shell, so which quotes don’t
matter in that regard, and it’s syntactically cleaner to use different
quotes than those used for the variable as a whole.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2617 bytes --]

Re: [PATCH] tzcode-native: quote ${CC}

[Denys Dmytriyenko]

On Thu, May 18, 2017 at 02:37:29PM -0700, Christopher Larson wrote:
> On Thu, May 18, 2017 at 11:57 AM, Khem Raj <raj.khem@gmail.com> wrote:
> 
> > On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko <denis@denix.org>
> > wrote:
> > > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:
> > >> build fails else with
> > >>
> > >> | + make -j 8 -l 6 cc=ccache gcc
> > >> | make: *** No rule to make target 'gcc'.  Stop.
> > >>
> > >> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> > >> ---
> > >>  meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > >> index 2084f79..165d2c6 100644
> > >> --- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > >> +++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > >> @@ -18,7 +18,7 @@ S = "${WORKDIR}"
> > >>
> > >>  inherit native
> > >>
> > >> -EXTRA_OEMAKE += "cc=${CC}"
> > >> +EXTRA_OEMAKE += "cc='${CC}'"
> > >
> > > Should these be double-quotes around ${CC}?
> >
> > I think this should work as such.
> 
> Indeed, it’s expanded by bitbake, not the shell, so which quotes don’t
> matter in that regard, and it’s syntactically cleaner to use different
> quotes than those used for the variable as a whole.

Unless ${CC} has shell variables inside for later expansion, isn't it?

-- 
Denys

Re: [PATCH] tzcode-native: quote ${CC}

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 2100 bytes --]

On Thu, May 18, 2017 at 2:54 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> On Thu, May 18, 2017 at 02:37:29PM -0700, Christopher Larson wrote:
> > On Thu, May 18, 2017 at 11:57 AM, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > > On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko <denis@denix.org>
> > > wrote:
> > > > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:
> > > >> build fails else with
> > > >>
> > > >> | + make -j 8 -l 6 cc=ccache gcc
> > > >> | make: *** No rule to make target 'gcc'.  Stop.
> > > >>
> > > >> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> > > >> ---
> > > >>  meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
> > > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > >> index 2084f79..165d2c6 100644
> > > >> --- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > >> +++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
> > > >> @@ -18,7 +18,7 @@ S = "${WORKDIR}"
> > > >>
> > > >>  inherit native
> > > >>
> > > >> -EXTRA_OEMAKE += "cc=${CC}"
> > > >> +EXTRA_OEMAKE += "cc='${CC}'"
> > > >
> > > > Should these be double-quotes around ${CC}?
> > >
> > > I think this should work as such.
> >
> > Indeed, it’s expanded by bitbake, not the shell, so which quotes don’t
> > matter in that regard, and it’s syntactically cleaner to use different
> > quotes than those used for the variable as a whole.
>
> Unless ${CC} has shell variables inside for later expansion, isn't it?


IMO doing so is a bug, as it relies on particulars of precisely when and
where the shell variable is expanded. Doing so often results in having to
escape it a precise number of times, depending on what context where you
want it expanded. More trouble than it’s worth, in my opinion. *shrug*
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 3565 bytes --]

Re: [PATCH] tzcode-native: quote ${CC}

[Enrico Scholz]

Denys Dmytriyenko <denis@denix.org> writes:

>> -EXTRA_OEMAKE += "cc=${CC}"
>> +EXTRA_OEMAKE += "cc='${CC}'"
>
> Should these be double-quotes around ${CC}?

I wrote it in this way:

- to 60%, because '' is more correct than "" in this context (see below)

- to 40%, because "" would clutter code too much and I can not say
  whether it must be quoted as \", \\" or whether perhaps plain " works
  too


A yet more correct solution would be

| export cc = "${CC}"

in the recipe (outside of do_*()) and perhaps adding '-e' to EXTRA_OEMAKE.


This handles additionally the case when 'CC' contains a single quote
(which causes misbehavior in my patch).

Double quotes are much more worse because CC must not contain '$', '`'
or '\\' (which is not uncommon in flags like '-DFOO()=\"bar\"').  In OE,
it is not expected that these characters are interpreted directly by the
shell (${CC} is passed properly quoted in the environment).

But all this does not matter... correct quoting is neglactted in OE and
bitbake; when you are lucky, commands are written as "foo '%s'" % path.
But nobody uses functions like 'pipes.quote()' or a non-shell variants
like subprocess.call(['foo', path]).

So, you can assume that '${FOO}' expands to the same value like "${FOO}".


Enrico
-- 
SIGMA Chemnitz GmbH       Registergericht:   Amtsgericht Chemnitz HRB 1750
Am Erlenwald 13           Geschaeftsfuehrer: Grit Freitag, Frank Pyritz
09128 Chemnitz

Re: [PATCH] tzcode-native: quote ${CC}

[Denys Dmytriyenko]

On Fri, May 19, 2017 at 01:37:59AM +0200, Enrico Scholz wrote:
> Denys Dmytriyenko <denis@denix.org> writes:
> 
> >> -EXTRA_OEMAKE += "cc=${CC}"
> >> +EXTRA_OEMAKE += "cc='${CC}'"
> >
> > Should these be double-quotes around ${CC}?
> 
> I wrote it in this way:
> 
> - to 60%, because '' is more correct than "" in this context (see below)
> 
> - to 40%, because "" would clutter code too much and I can not say
>   whether it must be quoted as \", \\" or whether perhaps plain " works
>   too

FWIW, bitbake handles nested quotes properly, no escaping needed:

+EXTRA_OEMAKE += "cc="${CC}""


> A yet more correct solution would be
> 
> | export cc = "${CC}"
> 
> in the recipe (outside of do_*()) and perhaps adding '-e' to EXTRA_OEMAKE.
> 
> 
> This handles additionally the case when 'CC' contains a single quote
> (which causes misbehavior in my patch).
> 
> Double quotes are much more worse because CC must not contain '$', '`'
> or '\\' (which is not uncommon in flags like '-DFOO()=\"bar\"').  In OE,
> it is not expected that these characters are interpreted directly by the
> shell (${CC} is passed properly quoted in the environment).
> 
> But all this does not matter... correct quoting is neglactted in OE and
> bitbake; when you are lucky, commands are written as "foo '%s'" % path.
> But nobody uses functions like 'pipes.quote()' or a non-shell variants
> like subprocess.call(['foo', path]).
> 
> So, you can assume that '${FOO}' expands to the same value like "${FOO}".

Yes, bitbake variables will be expanded properly regardles of the quotes. 
Passing a shell variable may cause problems, but may not be a good practice 
in general.

-- 
Denys

Re: [PATCH] tzcode-native: quote ${CC}

[Khem Raj]

On Fri, May 19, 2017 at 11:07 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Fri, May 19, 2017 at 01:37:59AM +0200, Enrico Scholz wrote:
>> Denys Dmytriyenko <denis@denix.org> writes:
>>
>> >> -EXTRA_OEMAKE += "cc=${CC}"
>> >> +EXTRA_OEMAKE += "cc='${CC}'"
>> >
>> > Should these be double-quotes around ${CC}?
>>
>> I wrote it in this way:
>>
>> - to 60%, because '' is more correct than "" in this context (see below)
>>
>> - to 40%, because "" would clutter code too much and I can not say
>>   whether it must be quoted as \", \\" or whether perhaps plain " works
>>   too
>
> FWIW, bitbake handles nested quotes properly, no escaping needed:
>
> +EXTRA_OEMAKE += "cc="${CC}""
>
>
>> A yet more correct solution would be
>>
>> | export cc = "${CC}"
>>
>> in the recipe (outside of do_*()) and perhaps adding '-e' to EXTRA_OEMAKE.
>>
>>
>> This handles additionally the case when 'CC' contains a single quote
>> (which causes misbehavior in my patch).
>>
>> Double quotes are much more worse because CC must not contain '$', '`'
>> or '\\' (which is not uncommon in flags like '-DFOO()=\"bar\"').  In OE,
>> it is not expected that these characters are interpreted directly by the
>> shell (${CC} is passed properly quoted in the environment).
>>
>> But all this does not matter... correct quoting is neglactted in OE and
>> bitbake; when you are lucky, commands are written as "foo '%s'" % path.
>> But nobody uses functions like 'pipes.quote()' or a non-shell variants
>> like subprocess.call(['foo', path]).
>>
>> So, you can assume that '${FOO}' expands to the same value like "${FOO}".
>
> Yes, bitbake variables will be expanded properly regardles of the quotes.
> Passing a shell variable may cause problems, but may not be a good practice
> in general.

you can toggle '' and "" strings, will keep the readability and embed
the string too

>
> --
> Denys
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[PATCH] tzcode-native: quote ${CC}

[Enrico Scholz]

build fails else with

| + make -j 8 -l 6 cc=ccache gcc
| make: *** No rule to make target 'gcc'.  Stop.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
 meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
index 2084f79..165d2c6 100644
--- a/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
+++ b/meta/recipes-extended/tzcode/tzcode-native_2017b.bb
@@ -18,7 +18,7 @@ S = "${WORKDIR}"
 
 inherit native
 
-EXTRA_OEMAKE += "cc=${CC}"
+EXTRA_OEMAKE += "cc='${CC}'"
 
 do_install () {
         install -d ${D}${bindir}/
-- 
2.9.4