From: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
To: stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
joshua.clayton-DelKAr4a3LpBDgjK7y7TUQ@public.gmane.org,
bst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs
Date: Thu, 18 May 2017 22:59:35 +0200 [thread overview]
Message-ID: <20170518225935.7948d7a5@crub> (raw)
In-Reply-To: <1495045422-19183-2-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust-ynQEQJNshbs@public.gmane.org wrote:
...
>+ if (!IS_ERR(conf->confd)) {
>+ if (!gpiod_get_raw_value_cansleep(conf->confd)) {
>+ dev_err(&mgr->dev, "CONF_DONE is low!\n");
as we agreed in the another thread, gpiod_get_value_cansleep()
should be used here. Another change: s/low/inactive/
--
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Anatolij Gustschin <agust@denx.de>
To: stillcompiling@gmail.com, joshua.clayton@uniwest.com, bst@pengutronix.de
Cc: linux-fpga@vger.kernel.org, atull@kernel.org,
moritz.fischer@ettus.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs
Date: Thu, 18 May 2017 22:59:35 +0200 [thread overview]
Message-ID: <20170518225935.7948d7a5@crub> (raw)
In-Reply-To: <1495045422-19183-2-git-send-email-agust@denx.de>
On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust@denx.de wrote:
...
>+ if (!IS_ERR(conf->confd)) {
>+ if (!gpiod_get_raw_value_cansleep(conf->confd)) {
>+ dev_err(&mgr->dev, "CONF_DONE is low!\n");
as we agreed in the another thread, gpiod_get_value_cansleep()
should be used here. Another change: s/low/inactive/
--
Anatolij
next prev parent reply other threads:[~2017-05-18 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 18:23 [PATCH v10 1/3] doc: dt: add altera-ps-spi binding document Anatolij Gustschin
2017-05-17 18:23 ` Anatolij Gustschin
[not found] ` <1495045422-19183-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-05-17 18:23 ` [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs Anatolij Gustschin
2017-05-17 18:23 ` Anatolij Gustschin
2017-05-18 11:46 ` Anatolij Gustschin
[not found] ` <1495045422-19183-2-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-05-18 20:59 ` Anatolij Gustschin [this message]
2017-05-18 20:59 ` Anatolij Gustschin
2017-05-17 18:23 ` [PATCH v10 3/3] ARM: dts: imx6q-evi: support cyclone-ps-spi Anatolij Gustschin
2017-05-17 18:23 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518225935.7948d7a5@crub \
--to=agust-ynqeqjnshbs@public.gmane.org \
--cc=atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=bst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=joshua.clayton-DelKAr4a3LpBDgjK7y7TUQ@public.gmane.org \
--cc=linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.