From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Anup Patel <anup.patel@broadcom.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req
Date: Fri, 19 May 2017 03:37:50 +0000 [thread overview]
Message-ID: <20170519032550.GL15061@localhost> (raw)
In-Reply-To: <20170517215850.5077-1-colin.king@canonical.com>
On Wed, May 17, 2017 at 10:58:50PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
>
> Detected by CoverityScan, CID#1436147 ("Logically dead code")
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Anup Patel <anup.patel@broadcom.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req
Date: Fri, 19 May 2017 08:55:50 +0530 [thread overview]
Message-ID: <20170519032550.GL15061@localhost> (raw)
In-Reply-To: <20170517215850.5077-1-colin.king@canonical.com>
On Wed, May 17, 2017 at 10:58:50PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
>
> Detected by CoverityScan, CID#1436147 ("Logically dead code")
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2017-05-19 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 21:58 [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req Colin King
2017-05-17 21:58 ` Colin King
2017-05-19 3:25 ` Vinod Koul [this message]
2017-05-19 3:37 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519032550.GL15061@localhost \
--to=vinod.koul@intel.com \
--cc=anup.patel@broadcom.com \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.