* [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del
@ 2017-05-19 6:36 Thomas Huth
2017-05-19 8:10 ` Paolo Bonzini
2017-05-19 8:25 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2017-05-19 6:36 UTC (permalink / raw)
To: qemu-devel, Gerd Hoffmann; +Cc: Paolo Bonzini, Dr David Alan Gilbert
The commands 'device_add' and 'device_del' should be used
nowadays instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hmp-commands.hx | 6 ++++--
vl.c | 6 ++++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index baeac47..e763606 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -676,7 +676,8 @@ ETEXI
STEXI
@item usb_add @var{devname}
@findex usb_add
-Add the USB device @var{devname}. For details of available devices see
+Add the USB device @var{devname}. This command is deprecated, please
+use @code{device_add} instead. For details of available devices see
@ref{usb_devices}
ETEXI
@@ -693,7 +694,8 @@ STEXI
@findex usb_del
Remove the USB device @var{devname} from the QEMU virtual USB
hub. @var{devname} has the syntax @code{bus.addr}. Use the monitor
-command @code{info usb} to see the devices you can remove.
+command @code{info usb} to see the devices you can remove. This
+command is deprecated, please use @code{device_del} instead.
ETEXI
{
diff --git a/vl.c b/vl.c
index 3ca6bd3..268a8d8 100644
--- a/vl.c
+++ b/vl.c
@@ -1435,6 +1435,9 @@ static int usb_parse(const char *cmdline)
void hmp_usb_add(Monitor *mon, const QDict *qdict)
{
const char *devname = qdict_get_str(qdict, "devname");
+
+ error_report("usb_add is deprecated, please use device_add instead");
+
if (usb_device_add(devname) < 0) {
error_report("could not add USB device '%s'", devname);
}
@@ -1443,6 +1446,9 @@ void hmp_usb_add(Monitor *mon, const QDict *qdict)
void hmp_usb_del(Monitor *mon, const QDict *qdict)
{
const char *devname = qdict_get_str(qdict, "devname");
+
+ error_report("usb_del is deprecated, please use device_del instead");
+
if (usb_device_del(devname) < 0) {
error_report("could not delete USB device '%s'", devname);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del
2017-05-19 6:36 [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del Thomas Huth
@ 2017-05-19 8:10 ` Paolo Bonzini
2017-05-19 8:25 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-05-19 8:10 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Gerd Hoffmann; +Cc: Dr David Alan Gilbert
On 19/05/2017 08:36, Thomas Huth wrote:
> The commands 'device_add' and 'device_del' should be used
> nowadays instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hmp-commands.hx | 6 ++++--
> vl.c | 6 ++++++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index baeac47..e763606 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -676,7 +676,8 @@ ETEXI
> STEXI
> @item usb_add @var{devname}
> @findex usb_add
> -Add the USB device @var{devname}. For details of available devices see
> +Add the USB device @var{devname}. This command is deprecated, please
> +use @code{device_add} instead. For details of available devices see
> @ref{usb_devices}
> ETEXI
>
> @@ -693,7 +694,8 @@ STEXI
> @findex usb_del
> Remove the USB device @var{devname} from the QEMU virtual USB
> hub. @var{devname} has the syntax @code{bus.addr}. Use the monitor
> -command @code{info usb} to see the devices you can remove.
> +command @code{info usb} to see the devices you can remove. This
> +command is deprecated, please use @code{device_del} instead.
> ETEXI
>
> {
> diff --git a/vl.c b/vl.c
> index 3ca6bd3..268a8d8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1435,6 +1435,9 @@ static int usb_parse(const char *cmdline)
> void hmp_usb_add(Monitor *mon, const QDict *qdict)
> {
> const char *devname = qdict_get_str(qdict, "devname");
> +
> + error_report("usb_add is deprecated, please use device_add instead");
> +
> if (usb_device_add(devname) < 0) {
> error_report("could not add USB device '%s'", devname);
> }
> @@ -1443,6 +1446,9 @@ void hmp_usb_add(Monitor *mon, const QDict *qdict)
> void hmp_usb_del(Monitor *mon, const QDict *qdict)
> {
> const char *devname = qdict_get_str(qdict, "devname");
> +
> + error_report("usb_del is deprecated, please use device_del instead");
> +
> if (usb_device_del(devname) < 0) {
> error_report("could not delete USB device '%s'", devname);
> }
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del
2017-05-19 6:36 [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del Thomas Huth
2017-05-19 8:10 ` Paolo Bonzini
@ 2017-05-19 8:25 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2017-05-19 8:25 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Gerd Hoffmann, Paolo Bonzini
* Thomas Huth (thuth@redhat.com) wrote:
> The commands 'device_add' and 'device_del' should be used
> nowadays instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hmp-commands.hx | 6 ++++--
> vl.c | 6 ++++++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index baeac47..e763606 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -676,7 +676,8 @@ ETEXI
> STEXI
> @item usb_add @var{devname}
> @findex usb_add
> -Add the USB device @var{devname}. For details of available devices see
> +Add the USB device @var{devname}. This command is deprecated, please
> +use @code{device_add} instead. For details of available devices see
> @ref{usb_devices}
> ETEXI
>
> @@ -693,7 +694,8 @@ STEXI
> @findex usb_del
> Remove the USB device @var{devname} from the QEMU virtual USB
> hub. @var{devname} has the syntax @code{bus.addr}. Use the monitor
> -command @code{info usb} to see the devices you can remove.
> +command @code{info usb} to see the devices you can remove. This
> +command is deprecated, please use @code{device_del} instead.
> ETEXI
>
> {
> diff --git a/vl.c b/vl.c
> index 3ca6bd3..268a8d8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1435,6 +1435,9 @@ static int usb_parse(const char *cmdline)
> void hmp_usb_add(Monitor *mon, const QDict *qdict)
> {
> const char *devname = qdict_get_str(qdict, "devname");
> +
> + error_report("usb_add is deprecated, please use device_add instead");
> +
> if (usb_device_add(devname) < 0) {
> error_report("could not add USB device '%s'", devname);
> }
> @@ -1443,6 +1446,9 @@ void hmp_usb_add(Monitor *mon, const QDict *qdict)
> void hmp_usb_del(Monitor *mon, const QDict *qdict)
> {
> const char *devname = qdict_get_str(qdict, "devname");
> +
> + error_report("usb_del is deprecated, please use device_del instead");
> +
> if (usb_device_del(devname) < 0) {
> error_report("could not delete USB device '%s'", devname);
> }
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-19 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-19 6:36 [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del Thomas Huth
2017-05-19 8:10 ` Paolo Bonzini
2017-05-19 8:25 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.