* [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt
@ 2017-05-19 7:27 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-05-19 7:27 UTC (permalink / raw)
To: Vinod Koul
Cc: Laurent Pinchart, Niklas Söderlund, Rob Herring,
Mark Rutland, dmaengine, devicetree, linux-renesas-soc,
Geert Uytterhoeven
The documentation for the "interrupt-names" property only mentions the
per-channel interrupts, while the error interrupt has always been
mandatory, too.
Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings
documentation")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
index 3316a9c2e638b98c..79a204d50234f287 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
@@ -30,8 +30,9 @@ Required Properties:
- interrupts: interrupt specifiers for the DMAC, one for each entry in
interrupt-names.
-- interrupt-names: one entry per channel, named "ch%u", where %u is the
- channel number ranging from zero to the number of channels minus one.
+- interrupt-names: one entry for the error interrupt, named "error", plus one
+ entry per channel, named "ch%u", where %u is the channel number ranging from
+ zero to the number of channels minus one.
- clock-names: "fck" for the functional clock
- clocks: a list of phandle + clock-specifier pairs, one for each entry
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt
@ 2017-05-19 7:27 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-05-19 7:27 UTC (permalink / raw)
To: Vinod Koul
Cc: Laurent Pinchart, Niklas Söderlund, Rob Herring,
Mark Rutland, dmaengine-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
The documentation for the "interrupt-names" property only mentions the
per-channel interrupts, while the error interrupt has always been
mandatory, too.
Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings
documentation")
Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
index 3316a9c2e638b98c..79a204d50234f287 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
@@ -30,8 +30,9 @@ Required Properties:
- interrupts: interrupt specifiers for the DMAC, one for each entry in
interrupt-names.
-- interrupt-names: one entry per channel, named "ch%u", where %u is the
- channel number ranging from zero to the number of channels minus one.
+- interrupt-names: one entry for the error interrupt, named "error", plus one
+ entry per channel, named "ch%u", where %u is the channel number ranging from
+ zero to the number of channels minus one.
- clock-names: "fck" for the functional clock
- clocks: a list of phandle + clock-specifier pairs, one for each entry
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt
2017-05-19 7:27 ` Geert Uytterhoeven
@ 2017-05-19 9:05 ` Niklas Söderlund
-1 siblings, 0 replies; 5+ messages in thread
From: Niklas Söderlund @ 2017-05-19 9:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vinod Koul, Laurent Pinchart, Rob Herring, Mark Rutland,
dmaengine, devicetree, linux-renesas-soc
Hi Geert,
On 2017-05-19 09:27:47 +0200, Geert Uytterhoeven wrote:
> The documentation for the "interrupt-names" property only mentions the
> per-channel interrupts, while the error interrupt has always been
> mandatory, too.
>
> Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings
> documentation")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> index 3316a9c2e638b98c..79a204d50234f287 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> @@ -30,8 +30,9 @@ Required Properties:
>
> - interrupts: interrupt specifiers for the DMAC, one for each entry in
> interrupt-names.
> -- interrupt-names: one entry per channel, named "ch%u", where %u is the
> - channel number ranging from zero to the number of channels minus one.
> +- interrupt-names: one entry for the error interrupt, named "error", plus one
> + entry per channel, named "ch%u", where %u is the channel number ranging from
> + zero to the number of channels minus one.
Reviewed-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
>
> - clock-names: "fck" for the functional clock
> - clocks: a list of phandle + clock-specifier pairs, one for each entry
> --
> 2.7.4
>
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt
@ 2017-05-19 9:05 ` Niklas Söderlund
0 siblings, 0 replies; 5+ messages in thread
From: Niklas Söderlund @ 2017-05-19 9:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vinod Koul, Laurent Pinchart, Rob Herring, Mark Rutland,
dmaengine, devicetree, linux-renesas-soc
Hi Geert,
On 2017-05-19 09:27:47 +0200, Geert Uytterhoeven wrote:
> The documentation for the "interrupt-names" property only mentions the
> per-channel interrupts, while the error interrupt has always been
> mandatory, too.
>
> Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings
> documentation")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> index 3316a9c2e638b98c..79a204d50234f287 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> @@ -30,8 +30,9 @@ Required Properties:
>
> - interrupts: interrupt specifiers for the DMAC, one for each entry in
> interrupt-names.
> -- interrupt-names: one entry per channel, named "ch%u", where %u is the
> - channel number ranging from zero to the number of channels minus one.
> +- interrupt-names: one entry for the error interrupt, named "error", plus one
> + entry per channel, named "ch%u", where %u is the channel number ranging from
> + zero to the number of channels minus one.
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> - clock-names: "fck" for the functional clock
> - clocks: a list of phandle + clock-specifier pairs, one for each entry
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt
2017-05-19 7:27 ` Geert Uytterhoeven
(?)
(?)
@ 2017-05-19 9:28 ` Vinod Koul
-1 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2017-05-19 9:28 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Laurent Pinchart, Niklas Söderlund, Rob Herring,
Mark Rutland, dmaengine, devicetree, linux-renesas-soc
On Fri, May 19, 2017 at 09:27:47AM +0200, Geert Uytterhoeven wrote:
> The documentation for the "interrupt-names" property only mentions the
> per-channel interrupts, while the error interrupt has always been
> mandatory, too.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-19 9:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-19 7:27 [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt Geert Uytterhoeven
2017-05-19 7:27 ` Geert Uytterhoeven
2017-05-19 9:05 ` Niklas Söderlund
2017-05-19 9:05 ` Niklas Söderlund
2017-05-19 9:28 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.