From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@163.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next 1/3] netfilter: restart nf ct cleanup if hash resize happen
Date: Sun, 21 May 2017 10:09:24 +0200 [thread overview]
Message-ID: <20170521080924.GC1004@breakpoint.cc> (raw)
In-Reply-To: <1495345149-57674-2-git-send-email-zlpnobody@163.com>
Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> Similar to commit 474803d37e7f ("netfilter: cttimeout: unlink timeout
> obj again when hash resize happen"), when hash resize happen, we should
> try to do cleanup work from the 0#bucket again, so we will never miss
> the conntrack entries which we are intrested in. This is important for
> the module removal.
Right. However, I suggest to use the seqcount for this, as done here:
https://git.breakpoint.cc/cgit/fw/nf-next.git/commit/?h=nfct_iterate_cleanup_15&id=b4f7c51617df8c79e0f28d03c6ebc2c157b1fecd
next prev parent reply other threads:[~2017-05-21 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 5:39 [PATCH nf-next 0/3] netfilter: handle hash resize situation in nf_ct_iterate_cleanup Liping Zhang
2017-05-21 5:39 ` [PATCH nf-next 1/3] netfilter: restart nf ct cleanup if hash resize happen Liping Zhang
2017-05-21 8:09 ` Florian Westphal [this message]
2017-05-21 5:39 ` [PATCH nf-next 2/3] netfilter: nf_ct_helper: use nf_ct_iterate_cleanup to unlink helper objs Liping Zhang
2017-05-21 8:15 ` Florian Westphal
2017-05-21 10:17 ` Liping Zhang
2017-05-21 10:31 ` Florian Westphal
2017-05-21 11:05 ` Liping Zhang
2017-05-21 11:10 ` Florian Westphal
2017-05-21 5:39 ` [PATCH nf-next 3/3] netfilter: cttimeout: use nf_ct_iterate_cleanup to unlink timeout objs Liping Zhang
2017-05-21 8:07 ` [PATCH nf-next 0/3] netfilter: handle hash resize situation in nf_ct_iterate_cleanup Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521080924.GC1004@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.