From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, Liping Zhang <zlpnobody@163.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next 2/3] netfilter: nf_ct_helper: use nf_ct_iterate_cleanup to unlink helper objs
Date: Sun, 21 May 2017 13:10:47 +0200 [thread overview]
Message-ID: <20170521111047.GF1004@breakpoint.cc> (raw)
In-Reply-To: <CAML_gOd3gqwTisxo64nxRbUoq_1QovyLTf=hxG=ks-Tv0h_tMw@mail.gmail.com>
Liping Zhang <zlpnobody@gmail.com> wrote:
> Yes, here we should use clear_bit(IPS_SRC_NAT_DONE_BIT, &ct->status);
> (For IPS_DST_NAT_DONE, we don't care about it, so we can
> leave it unchanged.)
Oh, right.
> > Thats also broken(racy). We have to audit all the non-atomic writes of
> > ct->status and change them to set/clear_bit()...
>
> I audited the related codes just now, this seems to be the last
> ct->status writer which use non-atomic bit operation(of course,
> except these unconfirmed ct->status writer).
>
> I will have a further and closer check. If you are not opposed to,
> I can send a related patch to fix this. :)
That would be great, thanks Liping!
next prev parent reply other threads:[~2017-05-21 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 5:39 [PATCH nf-next 0/3] netfilter: handle hash resize situation in nf_ct_iterate_cleanup Liping Zhang
2017-05-21 5:39 ` [PATCH nf-next 1/3] netfilter: restart nf ct cleanup if hash resize happen Liping Zhang
2017-05-21 8:09 ` Florian Westphal
2017-05-21 5:39 ` [PATCH nf-next 2/3] netfilter: nf_ct_helper: use nf_ct_iterate_cleanup to unlink helper objs Liping Zhang
2017-05-21 8:15 ` Florian Westphal
2017-05-21 10:17 ` Liping Zhang
2017-05-21 10:31 ` Florian Westphal
2017-05-21 11:05 ` Liping Zhang
2017-05-21 11:10 ` Florian Westphal [this message]
2017-05-21 5:39 ` [PATCH nf-next 3/3] netfilter: cttimeout: use nf_ct_iterate_cleanup to unlink timeout objs Liping Zhang
2017-05-21 8:07 ` [PATCH nf-next 0/3] netfilter: handle hash resize situation in nf_ct_iterate_cleanup Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521111047.GF1004@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.