All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	linux-nvme@lists.infradead.org,
	Keith Busch <keith.busch@intel.com>,
	stable@vger.kernel.org, Zhang Yi <yizhan@redhat.com>
Subject: Re: [PATCH v2 1/3] nvme: use blk_mq_start_hw_queues() in nvme_kill_queues()
Date: Mon, 22 May 2017 22:49:21 +0800	[thread overview]
Message-ID: <20170522144920.GF15872@ming.t460p> (raw)
In-Reply-To: <20170522125140.GE11869@lst.de>

On Mon, May 22, 2017 at 02:51:40PM +0200, Christoph Hellwig wrote:
> On Mon, May 22, 2017 at 09:35:58AM +0800, Ming Lei wrote:
> > In theory, it should be OK to stop and start queues again before the final
> > removal, so how about the following:
> > 
> >  		 * Note: We must make sure to not put the queues into being stopped
> > 		 forever from now until the final removal.
> 
> Maybe:
> 		 * Note that we must ensure the queues are not stopped
> 		 * when the final removal happens.
> 
> ?

Yeah, that is it, :-)

Thanks,
Ming

WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH v2 1/3] nvme: use blk_mq_start_hw_queues() in nvme_kill_queues()
Date: Mon, 22 May 2017 22:49:21 +0800	[thread overview]
Message-ID: <20170522144920.GF15872@ming.t460p> (raw)
In-Reply-To: <20170522125140.GE11869@lst.de>

On Mon, May 22, 2017@02:51:40PM +0200, Christoph Hellwig wrote:
> On Mon, May 22, 2017@09:35:58AM +0800, Ming Lei wrote:
> > In theory, it should be OK to stop and start queues again before the final
> > removal, so how about the following:
> > 
> >  		 * Note: We must make sure to not put the queues into being stopped
> > 		 forever from now until the final removal.
> 
> Maybe:
> 		 * Note that we must ensure the queues are not stopped
> 		 * when the final removal happens.
> 
> ?

Yeah, that is it, :-)

Thanks,
Ming

  reply	other threads:[~2017-05-22 14:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-20  3:56 [PATCH v2 0/3] nvme: fix hang in path of removing disk Ming Lei
2017-05-20  3:56 ` Ming Lei
2017-05-20  3:56 ` [PATCH v2 1/3] nvme: use blk_mq_start_hw_queues() in nvme_kill_queues() Ming Lei
2017-05-20  3:56   ` Ming Lei
2017-05-21  6:20   ` Christoph Hellwig
2017-05-21  6:20     ` Christoph Hellwig
2017-05-22  1:35     ` Ming Lei
2017-05-22  1:35       ` Ming Lei
2017-05-22 12:51       ` Christoph Hellwig
2017-05-22 12:51         ` Christoph Hellwig
2017-05-22 14:49         ` Ming Lei [this message]
2017-05-22 14:49           ` Ming Lei
2017-05-22  5:35   ` Keith Busch
2017-05-22  5:35     ` Keith Busch
2017-05-22  7:41   ` Johannes Thumshirn
2017-05-22  7:41     ` Johannes Thumshirn
2017-05-20  3:56 ` [PATCH v2 2/3] nvme: avoid to use blk_mq_abort_requeue_list() Ming Lei
2017-05-20  3:56   ` Ming Lei
2017-05-20  5:34   ` Ming Lei
2017-05-20  5:34     ` Ming Lei
2017-05-21  6:22     ` Christoph Hellwig
2017-05-21  6:22       ` Christoph Hellwig
2017-05-22  7:42     ` Johannes Thumshirn
2017-05-22  7:42       ` Johannes Thumshirn
2017-05-22  5:35   ` Keith Busch
2017-05-22  5:35     ` Keith Busch
2017-05-20  3:56 ` [PATCH v2 3/3] blk-mq: remove blk_mq_abort_requeue_list() Ming Lei
2017-05-20  3:56   ` Ming Lei
2017-05-21  6:22   ` Christoph Hellwig
2017-05-21  6:22     ` Christoph Hellwig
2017-05-22  5:36   ` Keith Busch
2017-05-22  5:36     ` Keith Busch
2017-05-22  7:43   ` Johannes Thumshirn
2017-05-22  7:43     ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522144920.GF15872@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    --cc=yizhan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.