From: Andrew Lunn <andrew@lunn.ch>
To: Timur Tabi <timur@codeaurora.org>
Cc: Zefir Kurtisi <zefir.kurtisi@neratec.com>,
netdev@vger.kernel.org, f.fainelli@gmail.com,
David Miller <davem@davemloft.net>,
Manoj Iyer <manoj.iyer@canonical.com>,
jhugo@codeaurora.org
Subject: Re: [PATCH 2/2] at803x: double check SGMII side autoneg
Date: Tue, 23 May 2017 18:07:22 +0200 [thread overview]
Message-ID: <20170523160722.GC21169@lunn.ch> (raw)
In-Reply-To: <a8415b8b-1713-053d-41d3-2577c5a53c8b@codeaurora.org>
On Tue, May 23, 2017 at 10:54:57AM -0500, Timur Tabi wrote:
> On 05/22/2017 04:32 PM, Andrew Lunn wrote:
> >> I'll have to test this, but what do I do if I don't get another interrupt?
> > It probably means interrupts cannot be used. Poll it.
>
> I will test that to see what happens, but I believe the real problem is that
> the at803x driver is lying when it says that the link is not okay. I think
> the link is okay, and that's why I'm not getting any more interrupts. I
> don't think I should have to drop interrupt support in my MAC driver because
> one specific PHY driver is broken.
If it turns out the PHY hardware is broken, the phy driver itself can
force it back to polling by setting phydev->irq to PHY_POLL in its
probe() function.
Andrew
next prev parent reply other threads:[~2017-05-23 16:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:40 [PATCH 0/2] at803x: don't power-down SGMII link Zefir Kurtisi
2016-10-24 10:40 ` [PATCH 1/2] Revert "at803x: fix suspend/resume for SGMII link" Zefir Kurtisi
2016-10-27 20:05 ` David Miller
2016-10-24 10:40 ` [PATCH 2/2] at803x: double check SGMII side autoneg Zefir Kurtisi
2016-10-27 20:05 ` David Miller
2016-10-28 22:24 ` Timur Tabi
2016-11-01 11:13 ` Zefir Kurtisi
2017-01-17 23:32 ` Timur Tabi
2017-01-18 11:00 ` Zefir Kurtisi
2017-01-18 13:13 ` Timur Tabi
2017-01-18 13:53 ` Zefir Kurtisi
2017-01-18 15:02 ` Timur Tabi
2017-01-19 9:43 ` Zefir Kurtisi
2017-01-19 18:01 ` Florian Fainelli
2017-01-20 2:38 ` Timur Tabi
2017-01-20 15:31 ` Zefir Kurtisi
2017-05-22 20:12 ` Timur Tabi
2017-05-22 21:02 ` Andrew Lunn
2017-05-22 21:10 ` Florian Fainelli
2017-05-22 21:19 ` Timur Tabi
2017-05-22 21:50 ` Florian Fainelli
2017-05-22 21:09 ` Andrew Lunn
2017-05-22 21:29 ` Timur Tabi
2017-05-22 21:32 ` Andrew Lunn
2017-05-23 15:54 ` Timur Tabi
2017-05-23 16:07 ` Andrew Lunn [this message]
2017-05-23 16:33 ` Timur Tabi
2017-05-24 7:18 ` Matthias May
2017-05-24 13:29 ` Timur Tabi
2017-05-24 13:40 ` Andrew Lunn
2017-05-24 13:48 ` Timur Tabi
2017-05-24 14:09 ` Andrew Lunn
2017-05-24 18:58 ` Timur Tabi
2017-05-24 19:34 ` Andrew Lunn
2017-05-24 20:57 ` Timur Tabi
2017-05-24 21:15 ` Andrew Lunn
2017-05-24 21:20 ` Timur Tabi
2017-05-24 21:28 ` Florian Fainelli
2017-05-24 21:32 ` Timur Tabi
2017-05-24 21:36 ` Florian Fainelli
2017-05-24 22:03 ` Timur Tabi
2017-05-24 21:19 ` Florian Fainelli
2017-06-01 11:45 ` Zefir Kurtisi
2017-06-01 14:48 ` Timur Tabi
2016-10-25 17:31 ` [PATCH 0/2] at803x: don't power-down SGMII link Timur Tabi
2016-10-27 8:05 ` Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523160722.GC21169@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jhugo@codeaurora.org \
--cc=manoj.iyer@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.