From: Eduardo Valentin <edubezval@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linaro-kernel@lists.linaro.org,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Punit Agrawal <punit.agrawal@arm.com>
Subject: Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core
Date: Tue, 23 May 2017 21:03:08 -0700 [thread overview]
Message-ID: <20170524040306.GA3501@localhost.localdomain> (raw)
In-Reply-To: <20170524035352.GO6510@vireshk-i7>
[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]
Viresh,
On Wed, May 24, 2017 at 09:23:52AM +0530, Viresh Kumar wrote:
> On 23-05-17, 19:41, Eduardo Valentin wrote:
> > Hey,
> >
> > On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote:
> > > Hi Guys,
> > >
> > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid
> > > high thermal states for a platform. But it wasn't glued really well with
> > > cpufreq core. For example clipped-cpus is copied from the policy
> > > structure and its much better to use the policy->cpus (or related_cpus)
> > > fields directly as they may have got updated. Not that things were
> > > broken before this series, but they can be optimized a bit more.
> > >
> > > This series tries to improve interactions between cpufreq core and
> > > cpu_cooling driver and does some fixes/cleanups to the cpu_cooling
> > > driver.
> > >
> > > I have tested it on ARM 32 (exynos) and 64 bit (hikey) boards (haven't
> > > tested the power specific bits).
> > >
> > > Lukasz from ARM has been very generous in testing and finding out few
> > > bugs in the earlier versions and getting those fixed. He has
> > > successfully tested the new version on his ARM big LITTLE Juno board.
> > >
> > > Pushed here as well:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git thermal/cooling
> > >
> > > V3->V4:
> >
> >
> > Took this version into my -linus branch for the next merge window.
> > Including the patch to remove the checkpatch warning. But please send
> > an extra patch to fix the style pointed on patch 8.
>
> Thanks Eduardo.
>
> But I am not sure what's left there to be fixed :(
>
> There were two warnings with patch 8, s/kmalloc/kmalloc_array and line
> over 80 columns and both were fixed by the patch I sent separately.
You are right, you are done here. This was probably a bug in my script
showing old checkpatch results on patch 8, somehow.
Sorry for the noise.
>
> --
> viresh
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-05-24 4:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 10:27 [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 02/17] thermal: cpu_cooling: rearrange globals Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev Viresh Kumar
2017-05-23 6:37 ` Zhang Rui
2017-05-23 7:03 ` [PATCH] thermal: cpu_cooling: Replace kmalloc with kmalloc_array Viresh Kumar
2017-05-24 2:27 ` Eduardo Valentin
2017-05-24 3:51 ` Viresh Kumar
2017-05-23 7:04 ` [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 04/17] thermal: cpu_cooling: replace cool_dev with cdev Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 05/17] thermal: cpu_cooling: remove cpufreq_cooling_get_level() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 06/17] thermal: cpu_cooling: get rid of a variable in cpufreq_set_cur_state() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 07/17] thermal: cpu_cooling: use cpufreq_policy to register cooling device Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 08/17] cpufreq: create cpufreq_table_count_valid_entries() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 09/17] thermal: cpu_cooling: store cpufreq policy Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 10/17] thermal: cpu_cooling: OPPs are registered for all CPUs Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 11/17] thermal: cpu_cooling: get rid of 'allowed_cpus' Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 12/17] thermal: cpu_cooling: merge frequency and power tables Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 13/17] thermal: cpu_cooling: create structure for idle time stats Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 14/17] thermal: cpu_cooling: get_level() can't fail Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 15/17] thermal: cpu_cooling: don't store cpu_dev in cpufreq_cdev Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 16/17] thermal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 17/17] thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device Viresh Kumar
2017-04-26 10:41 ` [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Lukasz Luba
2017-04-26 10:47 ` Viresh Kumar
2017-04-27 16:26 ` Eduardo Valentin
2017-04-28 4:24 ` Viresh Kumar
2017-05-26 4:57 ` Viresh Kumar
2017-05-28 0:29 ` Eduardo Valentin
2017-05-24 2:41 ` Eduardo Valentin
2017-05-24 3:53 ` Viresh Kumar
2017-05-24 4:03 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524040306.GA3501@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=amit.kachhap@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.