From: "Tobin C. Harding" <me@tobin.cc>
To: Richa Jha <richaj@cdac.in>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com,
me@tobin.cc
Subject: Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables
Date: Wed, 24 May 2017 10:30:24 +0000 [thread overview]
Message-ID: <20170524103024.GB2319@eros> (raw)
In-Reply-To: <1495612454-10505-1-git-send-email-richaj@cdac.in>
On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote:
[snip]
Nice work so far. I'm having trouble with your patches. Here are a few
nitpicks to help you on your way.
There are 4 emails in the last few days with similar subjects but they
are not linked together. Also your email subject does not start with '[PATCH]',
I doubt they will be picked up without it. You should read
Documentation/process/submitting-patches.rst.
There are some other issues with your subject line and commit-log, if
you would like further comments please ask.
So for initial patch the subject is something like
[PATCH] staging: foo: Fix identifiers, hungarian notation and camel case
If you submit version 2, it will then be
[PATCH v2] staging: foo: Fix identifiers, hungarian notation and camel case
Good luck,
Tobin.
WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: Richa Jha <richaj@cdac.in>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com,
me@tobin.cc
Subject: Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables
Date: Wed, 24 May 2017 20:30:24 +1000 [thread overview]
Message-ID: <20170524103024.GB2319@eros> (raw)
In-Reply-To: <1495612454-10505-1-git-send-email-richaj@cdac.in>
On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote:
[snip]
Nice work so far. I'm having trouble with your patches. Here are a few
nitpicks to help you on your way.
There are 4 emails in the last few days with similar subjects but they
are not linked together. Also your email subject does not start with '[PATCH]',
I doubt they will be picked up without it. You should read
Documentation/process/submitting-patches.rst.
There are some other issues with your subject line and commit-log, if
you would like further comments please ask.
So for initial patch the subject is something like
[PATCH] staging: foo: Fix identifiers, hungarian notation and camel case
If you submit version 2, it will then be
[PATCH v2] staging: foo: Fix identifiers, hungarian notation and camel case
Good luck,
Tobin.
next prev parent reply other threads:[~2017-05-24 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 7:54 staging: sm750fb: removed hungarian prfx and replace CamelCase variables Richa Jha
2017-05-24 7:57 ` Richa Jha
2017-05-24 10:30 ` Tobin C. Harding [this message]
2017-05-24 10:30 ` Tobin C. Harding
-- strict thread matches above, loose matches on Subject: below --
2017-05-23 13:07 Richa Jha
2017-05-23 13:19 ` Richa Jha
2017-05-24 2:07 ` Tobin C. Harding
2017-05-24 2:07 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524103024.GB2319@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richaj@cdac.in \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.