From: Jonathan Cameron <jic23@kernel.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Marc Titinger <mtitinger@baylibre.com>
Subject: Re: [PATCH v2 1/3] iio: adc: ina2xx: Make use of attribute flags consistent on all channels
Date: Wed, 24 May 2017 20:44:10 +0100 [thread overview]
Message-ID: <20170524204410.51fec937@kernel.org> (raw)
In-Reply-To: <2340f65ef51843f2b4fada09ecbb9048@rwthex-w2-b.rwth-ad.de>
On Wed, 24 May 2017 02:09:05 +0200
Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> Flags for shared channel attributes should be set on all channels of a
> channel set. I.e. SAMP_FREQUENCY and OVERSAMPLING_RATIO are set on the
> in_voltage{0,1} channels, thus should be set on in_power, in_current.
>
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Applied to the togreg branch of iio.git.
Thanks for tidying this up.
Jonathan
> ---
> drivers/iio/adc/ina2xx-adc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 6b588ac3130c..bba10a1b2fcb 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -442,6 +442,8 @@ static ssize_t ina2xx_shunt_resistor_store(struct device *dev,
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> BIT(IIO_CHAN_INFO_SCALE) | \
> BIT(IIO_CHAN_INFO_INT_TIME), \
> + .info_mask_shared_by_dir = BIT(IIO_CHAN_INFO_SAMP_FREQ) | \
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \
> .scan_index = (_index), \
> .scan_type = { \
> .sign = 'u', \
next prev parent reply other threads:[~2017-05-24 19:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170524000907.7788-1-stefan.bruens@rwth-aachen.de>
2017-05-24 0:09 ` [PATCH v2 1/3] iio: adc: ina2xx: Make use of attribute flags consistent on all channels Stefan Brüns
2017-05-24 19:44 ` Jonathan Cameron [this message]
2017-05-24 0:09 ` [PATCH v2 2/3] iio: adc: Fix integration time/averaging for INA219/220 Stefan Brüns
2017-05-24 19:50 ` Jonathan Cameron
2017-05-28 16:00 ` Jonathan Cameron
2017-06-03 9:03 ` Jonathan Cameron
2017-05-24 0:09 ` [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready flag Stefan Brüns
2017-05-24 19:53 ` Jonathan Cameron
2017-05-24 19:56 ` Jonathan Cameron
2017-06-19 18:24 ` Brüns, Stefan
2017-06-19 18:24 ` Brüns, Stefan
2017-06-19 18:30 ` Andrew F. Davis
2017-06-21 19:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524204410.51fec937@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtitinger@baylibre.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.