[PATCH] um: add dummy ioremap and iounmap functions

[PATCH] um: add dummy ioremap and iounmap functions

[Logan Gunthorpe]

The user mode architecture does not provide ioremap or iounmap, and
because of this, the arch won't build when the functions are used in some
core libraries.

I have designs to use these functions in scatterlist.c where they'd
almost certainly never be called on the um architecture but it does need
to compile.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Stephen Bates <sbates@raithlin.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
---
 arch/um/include/asm/io.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 arch/um/include/asm/io.h

diff --git a/arch/um/include/asm/io.h b/arch/um/include/asm/io.h
new file mode 100644
index 0000000..8f35d57
--- /dev/null
+++ b/arch/um/include/asm/io.h
@@ -0,0 +1,17 @@
+#ifndef _ASM_UM_IO_H
+#define _ASM_UM_IO_H
+
+#define ioremap ioremap
+static inline void __iomem *ioremap(phys_addr_t offset, size_t size)
+{
+	return (void __iomem *)(unsigned long)offset;
+}
+
+#define iounmap iounmap
+static inline void iounmap(void __iomem *addr)
+{
+}
+
+#include <asm-generic/io.h>
+
+#endif
-- 
2.1.4

Re: [PATCH] um: add dummy ioremap and iounmap functions

[Al Viro]

On Wed, May 24, 2017 at 04:00:52PM -0600, Logan Gunthorpe wrote:
> The user mode architecture does not provide ioremap or iounmap, and
> because of this, the arch won't build when the functions are used in some
> core libraries.
> 
> I have designs to use these functions in scatterlist.c where they'd
> almost certainly never be called on the um architecture but it does need
> to compile.

Then make it fail there.

Incidentally, s390 has ioremap() only when CONFIG_PCI is set.

Re: [PATCH] um: add dummy ioremap and iounmap functions

[Logan Gunthorpe]

On 24/05/17 04:05 PM, Al Viro wrote:
>> I have designs to use these functions in scatterlist.c where they'd
>> almost certainly never be called on the um architecture but it does need
>> to compile.
> 
> Then make it fail there.

Ok, will do. I'll send a v2 patch shortly.

> Incidentally, s390 has ioremap() only when CONFIG_PCI is set.

Hmm, ok, I'll take a peek. The kbuild robot never reported any build
issues with that architecture. I did see exactly this on the tile
architecture which I sent another patch for (that your feedback also
applies to).

Thanks for the quick review and feedback,

Logan