From: me@tobin.cc (Tobin C. Harding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.
Date: Thu, 25 May 2017 09:28:18 +1000 [thread overview]
Message-ID: <20170524232818.GF2319@eros> (raw)
In-Reply-To: <1495636394-2431-1-git-send-email-srishtishar@gmail.com>
On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
This driver is not in Greg KH's staging tree. You may like to work off
of that tree when doing staging patches.
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
To aid you future patches here are a couple of minor comments for you.
> fixed a trailing */ issue
You may like to be more explicit here using the format described in
Documentation/process/submitting-patches.rst (Section 2 Describe your
changes). This goes for your subject line as well.
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> index a4ffa1b..38fabab 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> @@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
> struct snd_ctl_elem_value *ucontrol)
> {
> /* bcm2835 supports only consumer mode and sets all other format flags
> - * automatically. So the only thing left is signalling non-audio
> - * content */
> + * automatically. So the only thing left is signalling non-audio content
> + */
And for completeness this is the block comment style in networking
code, the rest of the kernel uses the format
/*
* block comment blah blah
* on multiple lines
*/
Good luck,
Tobin.
WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: srishti sharma <srishtishar@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
f.fainelli@gmail.com, sbranden@broadcom.com,
swarren@wwwdotorg.org, rjui@broadcom.com, lee@kernel.org,
vicmos89@gmail.com, linux-kernel@vger.kernel.org,
eric@anholt.net, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, mzoran@crowfest.net,
dan.carpenter@oracle.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.
Date: Thu, 25 May 2017 09:28:18 +1000 [thread overview]
Message-ID: <20170524232818.GF2319@eros> (raw)
In-Reply-To: <1495636394-2431-1-git-send-email-srishtishar@gmail.com>
On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
This driver is not in Greg KH's staging tree. You may like to work off
of that tree when doing staging patches.
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
To aid you future patches here are a couple of minor comments for you.
> fixed a trailing */ issue
You may like to be more explicit here using the format described in
Documentation/process/submitting-patches.rst (Section 2 Describe your
changes). This goes for your subject line as well.
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> index a4ffa1b..38fabab 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> @@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
> struct snd_ctl_elem_value *ucontrol)
> {
> /* bcm2835 supports only consumer mode and sets all other format flags
> - * automatically. So the only thing left is signalling non-audio
> - * content */
> + * automatically. So the only thing left is signalling non-audio content
> + */
And for completeness this is the block comment style in networking
code, the rest of the kernel uses the format
/*
* block comment blah blah
* on multiple lines
*/
Good luck,
Tobin.
next prev parent reply other threads:[~2017-05-24 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 14:33 [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue srishti sharma
2017-05-24 14:33 ` srishti sharma
2017-05-24 23:28 ` Tobin C. Harding [this message]
2017-05-24 23:28 ` Tobin C. Harding
2017-05-25 5:22 ` srishti sharma
2017-05-25 5:22 ` srishti sharma
2017-05-25 6:59 ` Stefan Wahren
2017-05-25 6:59 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524232818.GF2319@eros \
--to=me@tobin.cc \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.