From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
Date: Thu, 25 May 2017 16:20:32 +0800 [thread overview]
Message-ID: <20170525082030.GB26102@dragon> (raw)
In-Reply-To: <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> >
> > Please keep these labelled nodes sort alphabetically.
>
> Ok
>
> >> + bus-num = <1>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_dspi2>;
> >> + status = "okay";
> >
> > We usually have 'status' line at the bottom of property list.
>
> Ok
>
> >> + spi-num-chipselects = <2>;
> >> +
> >> + hi8435 at 1 {
> >
> > Node name should be something generic, while label can be specific
> > model name. The following form might be better.
> >
> > hi8435: sensor at 1
>
> Ok
>
> Although the same file, in lines nearby, has m25p128 at 0 and at93c46d at 1.
It seems that I need more eyes to help review.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Nikita Yushchenko
<nikita.yoush-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chris Healy <Chris.Healy-c8ZVq/bFV1I@public.gmane.org>,
Jeff White <Jeff.White-c8ZVq/bFV1I@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
Date: Thu, 25 May 2017 16:20:32 +0800 [thread overview]
Message-ID: <20170525082030.GB26102@dragon> (raw)
In-Reply-To: <eb86f383-3c27-2276-6213-99c5143420f5-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> >
> > Please keep these labelled nodes sort alphabetically.
>
> Ok
>
> >> + bus-num = <1>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_dspi2>;
> >> + status = "okay";
> >
> > We usually have 'status' line at the bottom of property list.
>
> Ok
>
> >> + spi-num-chipselects = <2>;
> >> +
> >> + hi8435@1 {
> >
> > Node name should be something generic, while label can be specific
> > model name. The following form might be better.
> >
> > hi8435: sensor@1
>
> Ok
>
> Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.
It seems that I need more eyes to help review.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Stefan Agner <stefan@agner.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Chris Healy <Chris.Healy@zii.aero>,
Jeff White <Jeff.White@zii.aero>
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
Date: Thu, 25 May 2017 16:20:32 +0800 [thread overview]
Message-ID: <20170525082030.GB26102@dragon> (raw)
In-Reply-To: <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> >
> > Please keep these labelled nodes sort alphabetically.
>
> Ok
>
> >> + bus-num = <1>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_dspi2>;
> >> + status = "okay";
> >
> > We usually have 'status' line at the bottom of property list.
>
> Ok
>
> >> + spi-num-chipselects = <2>;
> >> +
> >> + hi8435@1 {
> >
> > Node name should be something generic, while label can be specific
> > model name. The following form might be better.
> >
> > hi8435: sensor@1
>
> Ok
>
> Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.
It seems that I need more eyes to help review.
Shawn
next prev parent reply other threads:[~2017-05-25 8:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:10 [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko
2017-05-22 13:10 ` Nikita Yushchenko
2017-05-22 13:10 ` Nikita Yushchenko
2017-05-22 16:20 ` Stefan Agner
2017-05-22 16:20 ` Stefan Agner
2017-05-22 16:20 ` Stefan Agner
2017-05-22 16:29 ` Nikita Yushchenko
2017-05-22 16:29 ` Nikita Yushchenko
2017-05-22 16:29 ` Nikita Yushchenko
2017-05-22 18:21 ` Andrew Lunn
2017-05-22 18:21 ` Andrew Lunn
2017-05-23 6:02 ` Nikita Yushchenko
2017-05-23 6:02 ` Nikita Yushchenko
2017-05-23 6:02 ` Nikita Yushchenko
2017-05-25 7:19 ` Shawn Guo
2017-05-25 7:19 ` Shawn Guo
2017-05-25 7:19 ` Shawn Guo
2017-05-25 8:03 ` Nikita Yushchenko
2017-05-25 8:03 ` Nikita Yushchenko
2017-05-25 8:03 ` Nikita Yushchenko
2017-05-28 15:09 ` Jonathan Cameron
2017-05-28 15:09 ` Jonathan Cameron
2017-05-28 15:09 ` Jonathan Cameron
2017-05-25 7:00 ` Shawn Guo
2017-05-25 7:00 ` Shawn Guo
2017-05-25 7:00 ` Shawn Guo
2017-05-25 8:06 ` Nikita Yushchenko
2017-05-25 8:06 ` Nikita Yushchenko
2017-05-25 8:06 ` Nikita Yushchenko
2017-05-25 8:20 ` Shawn Guo [this message]
2017-05-25 8:20 ` Shawn Guo
2017-05-25 8:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525082030.GB26102@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.