All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aliza Minkov <minkov.al@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
	driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix multiple blank lines coding style problem
Date: Thu, 25 May 2017 13:37:18 +0200	[thread overview]
Message-ID: <20170525113718.GA12683@kroah.com> (raw)
In-Reply-To: <1495712011-7051-1-git-send-email-minkov.al@gmail.com>

On Thu, May 25, 2017 at 02:33:31PM +0300, Aliza Minkov wrote:
> According to the coding-style documentation, functions in source files
> should be separated with one blank line. Redundant blank lines were
> removed from this source file, in accordance with coding-style
> documentation.
> 
> Signed-off-by: Aliza Minkov <minkov.al@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 2 --
>  1 file changed, 2 deletions(-)

Getting closer, please look at your subject, and compare it to the
subjects that other patches for this driver/file have had in the past,
and fix it up that way.

Also, you need to now start versioning your patch, as you are submitting
the same one multiple times, SubmittingPatches will tell you how to
properly do that.

thanks,

greg k-h

  reply	other threads:[~2017-05-25 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 11:33 [PATCH] fix multiple blank lines coding style problem Aliza Minkov
2017-05-25 11:37 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-05-25  9:22 Aliza Minkov
2017-05-25 10:28 ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525113718.GA12683@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=minkov.al@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.