[PATCH] fix multiple blank lines coding style problem

[PATCH] fix multiple blank lines coding style problem

[Aliza Minkov]

According to the coding-style documentation, functions in source files
should be separated with one blank line. Redundant blank lines were
removed from this source file, in accordance with coding-style
documentation.

Signed-off-by: Aliza Minkov <minkov.al@gmail.com>
---
 drivers/staging/dgnc/dgnc_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index 253f38b..c1b6079 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -96,7 +96,6 @@ static int dgnc_do_remap(struct dgnc_board *brd)
 	return 0;
 }
 
-
 /* A board has been found, initialize  it. */
 static struct dgnc_board *dgnc_found_board(struct pci_dev *pdev, int id)
 {
@@ -287,7 +286,6 @@ static void dgnc_free_irq(struct dgnc_board *brd)
 		free_irq(brd->irq, brd);
 }
 
-
  /*
   * As each timer expires, it determines (a) whether the "transmit"
   * waiter needs to be woken up, and (b) whether the poller needs to
-- 
1.9.1

Re: [PATCH] fix multiple blank lines coding style problem

[Greg KH]

On Thu, May 25, 2017 at 02:33:31PM +0300, Aliza Minkov wrote:
> According to the coding-style documentation, functions in source files
> should be separated with one blank line. Redundant blank lines were
> removed from this source file, in accordance with coding-style
> documentation.
> 
> Signed-off-by: Aliza Minkov <minkov.al@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 2 --
>  1 file changed, 2 deletions(-)

Getting closer, please look at your subject, and compare it to the
subjects that other patches for this driver/file have had in the past,
and fix it up that way.

Also, you need to now start versioning your patch, as you are submitting
the same one multiple times, SubmittingPatches will tell you how to
properly do that.

thanks,

greg k-h

[PATCH] fix multiple blank lines coding style problem

[Aliza Minkov]

Signed-off-by: Aliza Minkov <minkov.al@gmail.com>
---
 drivers/staging/dgnc/dgnc_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index 253f38b..c1b6079 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -96,7 +96,6 @@ static int dgnc_do_remap(struct dgnc_board *brd)
 	return 0;
 }
 
-
 /* A board has been found, initialize  it. */
 static struct dgnc_board *dgnc_found_board(struct pci_dev *pdev, int id)
 {
@@ -287,7 +286,6 @@ static void dgnc_free_irq(struct dgnc_board *brd)
 		free_irq(brd->irq, brd);
 }
 
-
  /*
   * As each timer expires, it determines (a) whether the "transmit"
   * waiter needs to be woken up, and (b) whether the poller needs to
-- 
1.9.1

Re: [PATCH] fix multiple blank lines coding style problem

[Tobin C. Harding]

On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote:
> Signed-off-by: Aliza Minkov <minkov.al@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 2 --
>  1 file changed, 2 deletions(-)

Hi Aliza,

Well done getting your patch together. I think you might get an
automated message from Greg's patch robot so at the risk of repeating
the message here goes.

You will need to add a commit log in order for your patch to have a
chance of being picked up. Your commit summary is good, you may like
to read Documentation/process/submitting-patches.rst (Section 2
Describe your changes). Apart from that the patch looks good to me.

Good luck,
Tobin.