From: Greg KH <gregkh@linuxfoundation.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
peterz@infradead.org, vincent.guittot@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com, linux@arm.linux.org.uk,
sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
broonie@kernel.org
Subject: Re: [PATCH v4 6/8] arm,arm64,drivers: reduce scope of cap_parsing_failed
Date: Thu, 25 May 2017 15:13:07 +0200 [thread overview]
Message-ID: <20170525131307.GC16244@kroah.com> (raw)
In-Reply-To: <20170420144316.15632-7-juri.lelli@arm.com>
On Thu, Apr 20, 2017 at 03:43:14PM +0100, Juri Lelli wrote:
> Reduce the scope of cap_parsing_failed (making it static in
> drivers/base/arch_topology.c) by slightly changing {arm,arm64} DT
> parsing code.
>
> For arm checking for !cap_parsing_failed before calling normalize_
> cpu_capacity() is superfluous, as returning an error from parse_
> cpu_capacity() (above) means cap_from _dt is set to false.
>
> For arm64 we can simply check if raw_capacity points to something,
> which is not if capacity parsing has failed.
>
> Suggested-by: Morten Rasmussen <morten.rasmussen@arm.com>
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/8] arm,arm64,drivers: reduce scope of cap_parsing_failed
Date: Thu, 25 May 2017 15:13:07 +0200 [thread overview]
Message-ID: <20170525131307.GC16244@kroah.com> (raw)
In-Reply-To: <20170420144316.15632-7-juri.lelli@arm.com>
On Thu, Apr 20, 2017 at 03:43:14PM +0100, Juri Lelli wrote:
> Reduce the scope of cap_parsing_failed (making it static in
> drivers/base/arch_topology.c) by slightly changing {arm,arm64} DT
> parsing code.
>
> For arm checking for !cap_parsing_failed before calling normalize_
> cpu_capacity() is superfluous, as returning an error from parse_
> cpu_capacity() (above) means cap_from _dt is set to false.
>
> For arm64 we can simply check if raw_capacity points to something,
> which is not if capacity parsing has failed.
>
> Suggested-by: Morten Rasmussen <morten.rasmussen@arm.com>
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-05-25 13:13 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:43 [PATCH v4 0/8] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` [PATCH v4 1/8] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` [PATCH v4 2/8] Documentation/ABI: add information about cpu_capacity Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` [PATCH v4 4/8] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` [PATCH v4 5/8] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-05-25 13:12 ` Greg KH
2017-05-25 13:12 ` Greg KH
2017-04-20 14:43 ` [PATCH v4 7/8] arm,arm64,drivers: move externs in a new header file Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-05-25 13:13 ` Greg KH
2017-05-25 13:13 ` Greg KH
2017-04-20 14:43 ` [PATCH v4 8/8] arm,arm64,drivers: add a prefix to drivers arch_topology interfaces Juri Lelli
2017-04-20 14:43 ` [PATCH v4 8/8] arm, arm64, drivers: " Juri Lelli
2017-05-25 13:18 ` [PATCH v4 8/8] arm,arm64,drivers: " Greg KH
2017-05-25 13:18 ` Greg KH
[not found] ` <20170525131802.GE16244-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-05-26 10:10 ` Juri Lelli
2017-05-26 10:10 ` Juri Lelli
2017-05-26 10:10 ` Juri Lelli
2017-05-26 18:36 ` Greg KH
2017-05-26 18:36 ` Greg KH
2017-05-26 18:36 ` Greg KH
2017-05-29 9:20 ` Dietmar Eggemann
2017-05-29 9:20 ` Dietmar Eggemann
2017-05-29 9:58 ` Greg KH
2017-05-29 9:58 ` Greg KH
2017-05-29 10:46 ` Dietmar Eggemann
2017-05-29 10:46 ` Dietmar Eggemann
2017-05-30 14:59 ` Juri Lelli
2017-05-30 14:59 ` Juri Lelli
[not found] ` <20170420144316.15632-1-juri.lelli-5wv7dgnIgG8@public.gmane.org>
2017-04-20 14:43 ` [PATCH v4 3/8] arm: fix return value of parse_cpu_capacity Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:50 ` Vincent Guittot
2017-04-20 14:50 ` Vincent Guittot
2017-04-20 14:43 ` [PATCH v4 6/8] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-04-20 14:43 ` Juri Lelli
2017-05-25 13:13 ` Greg KH [this message]
2017-05-25 13:13 ` Greg KH
2017-05-11 8:48 ` [PATCH v4 0/8] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-05-11 8:48 ` Juri Lelli
2017-05-11 8:48 ` Juri Lelli
2017-05-11 8:59 ` Greg KH
2017-05-11 8:59 ` Greg KH
[not found] ` <20170511085952.GA6934-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-05-11 10:27 ` Juri Lelli
2017-05-11 10:27 ` Juri Lelli
2017-05-11 10:27 ` Juri Lelli
2017-05-24 14:45 ` Juri Lelli
2017-05-24 14:45 ` Juri Lelli
2017-05-25 13:18 ` Greg KH
2017-05-25 13:18 ` Greg KH
2017-05-25 13:18 ` Greg KH
[not found] ` <20170525131831.GF16244-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-05-25 13:30 ` Juri Lelli
2017-05-25 13:30 ` Juri Lelli
2017-05-25 13:30 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525131307.GC16244@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.